Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] libImpeller: Wire up Metal and Vulkan backends. #159512

Open
loic-sharma opened this issue Nov 26, 2024 · 2 comments · May be fixed by flutter/engine#56906
Open

[Impeller] libImpeller: Wire up Metal and Vulkan backends. #159512

loic-sharma opened this issue Nov 26, 2024 · 2 comments · May be fixed by flutter/engine#56906
Assignees
@chinmaygarde
Labels
e: impeller Impeller rendering backend issues and features requests e: libimpeller The standalone Impeller library with a single-header API. P3 Issues that are less important to the Flutter project team-engine Owned by Engine team triaged-engine Triaged by Engine team waiting for PR to land (fixed) A fix is in flight

Comments

@loic-sharma
Copy link
Member

No description provided.

@loic-sharma loic-sharma converted this from a draft issue Nov 26, 2024
@loic-sharma loic-sharma added e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team e: libimpeller The standalone Impeller library with a single-header API. labels Nov 26, 2024
@loic-sharma
Copy link
Member Author

(I converted this to an issue so that I can enable notifications on this item)

@jonahwilliams jonahwilliams added P3 Issues that are less important to the Flutter project triaged-engine Triaged by Engine team labels Dec 2, 2024
@chinmaygarde chinmaygarde self-assigned this Dec 2, 2024
chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this issue Dec 2, 2024
@chinmaygarde
[Impeller] libImpeller: Add support for Metal and Vulkan rendering.
43ea25f 
The tests were already parameterized. This enables the remaining backends.

Fixes flutter/flutter#159512
@chinmaygarde chinmaygarde linked a pull request Dec 2, 2024 that will close this issue
Open
@chinmaygarde
Copy link
Member

so that I can enable notifications on this item

Ah, yeah. I had made placeholders on the dashboard. Anyway, this is being completed in flutter/engine#56906 to round of the support for the MVP.

chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this issue Dec 10, 2024
@chinmaygarde
[Impeller] libImpeller: Add support for Metal and Vulkan rendering.
327902b 
The tests were already parameterized. This enables the remaining backends.

Fixes flutter/flutter#159512
chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this issue Dec 10, 2024
@chinmaygarde
[Impeller] libImpeller: Add support for Metal and Vulkan rendering.
56b8c08 
* Adds context creation and WSI routines for Metal and Vulkan.
* Enables all tests for the Metal, Vulkan, and OpenGLES backends.
* Separate standalone examples for Metal, Vulkan, and OpenGLES have been created. These will be packaged with the SDK.
  * Disallows the use of OpenGL ES on macOS.
* All new public methods are documented.
* The SDK version number has been bumped.
* Some incorrect nullability annotations were patched.
* Tests harness is overhauled to reuse the same underlying context as the playgrounds.

Fixes flutter/flutter#159512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chinmaygarde chinmaygarde

Labels
e: impeller Impeller rendering backend issues and features requests e: libimpeller The standalone Impeller library with a single-header API. P3 Issues that are less important to the Flutter project team-engine Owned by Engine team triaged-engine Triaged by Engine team waiting for PR to land (fixed) A fix is in flight
Projects
libImpeller
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Impeller] libImpeller: Add support for Metal and Vulkan rendering. chinmaygarde/flutter_engine
3 participants
@chinmaygarde @loic-sharma @jonahwilliams