[Impeller] libImpeller: Add support for Metal and Vulkan rendering. #56906
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
chinmaygarde
force-pushed
the
morebackends
branch
from
e78f74a to
327902b
Compare
* Adds context creation and WSI routines for Metal and Vulkan. * Enables all tests for the Metal, Vulkan, and OpenGLES backends. * Separate standalone examples for Metal, Vulkan, and OpenGLES have been created. These will be packaged with the SDK. * Disallows the use of OpenGL ES on macOS. * All new public methods are documented. * The SDK version number has been bumped. * Some incorrect nullability annotations were patched. * Tests harness is overhauled to reuse the same underlying context as the playgrounds. Fixes flutter/flutter#159512
chinmaygarde
force-pushed
the
morebackends
branch
from
327902b to
56b8c08
Compare
|
Ok, all done. All backends should be enabled, tested, documented, and have examples. I am sure more complicated WSI could be supported (like non vk_surface_khr swapchains) but we can add support for that as it becomes necessary. |
| impeller::ContextVK::Settings impeller_settings; | ||
| impeller_settings.shader_libraries_data = CreateShaderLibraryMappings(); | ||
| impeller_settings.cache_directory = fml::paths::GetCachesDirectory(); | ||
| impeller_settings.enable_validation = true; |
There was a problem hiding this comment.
should this be reading from the settings?
There was a problem hiding this comment.
Nice spot. This gave me so much trouble since reading from the settings was what I was doing initially. But we set setting to this to true here. This causes the system global proc. table to be initialized twice. And, depending on whether the second instance enabled or disables validations, proc. entries are zeroed out. So teardown of say the debug printers in the second context to be torn down won't find the proc. table entry for the deleter. And cause a crash.
There was a problem hiding this comment.
Oh, but you mentioned settings. While I was using switches (that the settings are inferred from). Perhaps I could steal the underlying contexts settings directly. Momentido.
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
|
This will need to be ported over to flutter/flutter. |
…161547) * Adds context creation and WSI routines for Metal and Vulkan. * Enables all tests for the Metal, Vulkan, and OpenGLES backends. * Separate standalone examples for Metal, Vulkan, and OpenGLES have been created. These will be packaged with the SDK. * Disallows the use of OpenGL ES on macOS. * All new public methods are documented. * The SDK version number has been bumped. * Some incorrect nullability annotations were patched. * Tests harness is overhauled to reuse the same underlying context as the playgrounds. * The C++ public header has been updated. Fixes #159512 Ports flutter/engine#56906
Fixes flutter/flutter#159512