Add Support for autofill with textContentType #13878

Evsio0n · 2019-11-15T19:47:13Z

textContentType implentation need to be updated in text_input.dart in Flutter SDK

textContentType implentation need to bu updated in text_input.dart in Flutter SDK

googlebot · 2019-11-15T19:47:19Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-11-15T19:47:19Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Evsio0n · 2019-11-15T19:48:54Z

@googlebot I signed it!

googlebot · 2019-11-15T19:48:59Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot · 2019-11-15T19:48:59Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Evsio0n · 2019-11-15T19:56:38Z

Some error, wait a minute.

ArtemMartus · 2019-11-17T14:19:26Z

So how's autofill implementation going?

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

justinmc

Just a quick review. It seems like this may be still in progress, so sorry for the early feedback. Feel free to mention me for help or review later. Thanks for taking this on!

justinmc · 2019-11-18T20:31:08Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

+static UITextContentType ToUITextContentType(NSDictionary* type){
+      NSString* contentType = type[@"textType"];
+    if ([contentType isEqualToString:@"TextContent.username"])
+        return UITextContentTypeUsername;


The above 3 lines have indentation problems. Indentation should be 2 spaces.

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

googlebot · 2019-11-21T12:19:39Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2019-11-21T12:19:39Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

ArtemMartus · 2019-11-21T16:13:51Z

@googlebot I consent

googlebot · 2019-11-21T16:14:13Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-11-21T16:14:13Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Evsio0n · 2019-11-21T16:33:58Z

#13878 flutter/flutter#33040

Evsio0n

You needs to sign Google CLA at https://cla.developers.google.com/

ArtemMartus · 2019-11-21T16:37:56Z

@googlebot I fixed it.

LongCatIsLooong · 2019-12-02T21:27:17Z

@Evsio0n it looks like these two commits: 785699a and 7ca9e4e are created under a different email address (that hasn't signed the CLA). Could you rebase these commits using the email address that you signed the CLA with?

Update FlutterTextInputPlugin.mm flutter ci formatting fix syntax error Set limitation to iOS 11 due to UITextContentTypeUsername is Up at iOS 11 modified: shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm Set limitation to iOS 11 due to UITextContentTypeUsername is Up at iOS 11 修改： shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

googlebot · 2019-12-03T10:02:12Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot · 2019-12-03T10:02:12Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Evsio0n · 2019-12-03T10:06:12Z

@Evsio0n it looks like these two commits: 785699a and 7ca9e4e are created under a different email address (that hasn't signed the CLA). Could you rebase these commits using the email address that you signed the CLA with?

Fixed, Thanks.

cbenhagen · 2019-12-03T14:05:33Z

@Evsio0n you might also want to fix the formatting issues mentioned in https://cirrus-ci.com/task/6514581622489088

cbracken · 2019-12-09T18:55:55Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

+ This file is to make ios 11 or higher device using autofill
+ 
+ Reference to  github.com/flutter/flutter/issues/33040
+ **/


Remove this doc comment since it doesn't add anything that the reader can't look up from UITextContentType or the commit comment from git blame.

cbracken · 2019-12-09T19:00:49Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

    _enablesReturnKeyAutomatically = NO;
    _keyboardAppearance = UIKeyboardAppearanceDefault;
    _keyboardType = UIKeyboardTypeDefault;
+    if(@available iOS (11.0,*))


The syntax above should be: if (@available(iOS 11.0, *))

cbracken · 2019-12-09T19:01:01Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm


 - (void)setTextInputClient:(int)client withConfiguration:(NSDictionary*)configuration {
  NSDictionary* inputType = configuration[@"inputType"];
+  if(@available iOS (11.0,*))


The syntax above should be: if (@available(iOS 11.0, *))

cbracken · 2019-12-09T19:01:06Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

  }

  _activeView.keyboardType = ToUIKeyboardType(inputType);
+  if(@available iOS (11.0,*))


The syntax above should be: if (@available(iOS 11.0, *))

cbracken · 2019-12-09T19:02:53Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

 - (void)setTextInputClient:(int)client withConfiguration:(NSDictionary*)configuration {
  NSDictionary* inputType = configuration[@"inputType"];
+  if(@available iOS (11.0,*))
+      NSDictionary* contentType = configuration[@"contentType"];


It looks like this is an unused variable.

This variable is referred by flutter/flutter#33040

It looks like this is an unused variable.

Maybe I will check CI After Exam Month

cbracken · 2020-02-03T19:12:12Z

Thanks for your contribution. Since we haven't seen any further progress on this, and it currently does not compile, we're going to reluctantly close this PR for now, but if you get time to address the comments, we'd be more than happy to take a look at a new PR. If you do send a new PR, it would be very useful to reference this one in the description in order to help reviewers see the previous context.

Evsio0n added 2 commits November 16, 2019 03:41

Add Support for autofill with textContentType

fd0f58d

textContentType implentation need to bu updated in text_input.dart in Flutter SDK

Update FlutterTextInputPlugin.mm

6077592

googlebot added the cla: no label Nov 15, 2019

googlebot added cla: yes and removed cla: no labels Nov 15, 2019

Evsio0n closed this Nov 15, 2019

AlexV525 mentioned this pull request Nov 15, 2019

Autofill support flutter/flutter#13015

Closed

Evsio0n reopened this Nov 15, 2019

ArtemMartus reviewed Nov 17, 2019

View reviewed changes

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm Outdated Show resolved Hide resolved

justinmc reviewed Nov 18, 2019

View reviewed changes

googlebot added cla: no and removed cla: yes labels Nov 21, 2019

Evsio0n mentioned this pull request Nov 21, 2019

TextField autofill for common user properties taken from iOS flutter/flutter#33040

Closed

Evsio0n commented Nov 21, 2019

View reviewed changes

Evsio0n requested a review from justinmc November 22, 2019 07:11

Evsio0n force-pushed the master branch from 81c3e17 to 928a091 Compare December 3, 2019 10:02

googlebot added cla: yes and removed cla: no labels Dec 3, 2019

Evsio0n closed this Dec 3, 2019

Evsio0n reopened this Dec 3, 2019

cbracken suggested changes Dec 9, 2019

View reviewed changes

cbracken closed this Feb 3, 2020

Add Support for autofill with textContentType #13878

Add Support for autofill with textContentType #13878

Uh oh!

Conversation

Evsio0n commented Nov 15, 2019

Uh oh!

googlebot commented Nov 15, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

googlebot commented Nov 15, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

Evsio0n commented Nov 15, 2019

Uh oh!

googlebot commented Nov 15, 2019

Uh oh!

googlebot commented Nov 15, 2019

Uh oh!

Evsio0n commented Nov 15, 2019

Uh oh!

ArtemMartus commented Nov 17, 2019

Uh oh!

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

googlebot commented Nov 21, 2019

Uh oh!

googlebot commented Nov 21, 2019

Uh oh!

ArtemMartus commented Nov 21, 2019

Uh oh!

googlebot commented Nov 21, 2019

Uh oh!

googlebot commented Nov 21, 2019

Uh oh!

Evsio0n commented Nov 21, 2019

Uh oh!

Evsio0n left a comment

Choose a reason for hiding this comment

Uh oh!

ArtemMartus commented Nov 21, 2019

Uh oh!

LongCatIsLooong commented Dec 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Dec 3, 2019

Uh oh!

googlebot commented Dec 3, 2019

Uh oh!

Evsio0n commented Dec 3, 2019

Uh oh!

cbenhagen commented Dec 3, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cbracken commented Feb 3, 2020

Uh oh!

Reviewers

Assignees

LongCatIsLooong commented Dec 2, 2019 •

edited

Loading