This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Allow custom embedders to post low memory notifications. #14506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a non-breaking addition to the stable Flutter Embedder API.
jason-simmons
approved these changes
Dec 16, 2019
cbracken
approved these changes
Dec 16, 2019
| // the raster cache and the secondary context caches to respond to | ||
| // notifications. Once that is in place, this test can be updated to actually | ||
| // ensure that the dispatched message is visible to engine subsystems. | ||
| ASSERT_EQ(FlutterEngineNotifyLowMemoryWarning(engine.get()), kSuccess); |
Member
There was a problem hiding this comment.
nit: We could check the Dart side gets the expected message if we added a .dart fixture here.
Member
Author
There was a problem hiding this comment.
Roger, I'll address this TODO after addressing the other items in xreffed issue.
| } | ||
|
|
||
| FLUTTER_EXPORT | ||
| FlutterEngineResult FlutterEngineNotifyLowMemoryWarning( |
Contributor
There was a problem hiding this comment.
Consider also calling Dart_NotifyLowMemory.
Member
Author
There was a problem hiding this comment.
I did not know that was a thing. I'll wire up in another patch. Thanks.
Member
Author
There was a problem hiding this comment.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 17, 2019
iskakaushik
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 18, 2019
* c260057 Roll src/third_party/dart fe9f30c3896e..8ad8abfb7463 (19 commits) (flutter/engine#14480) * 47c1dde Roll src/third_party/skia d0840ecf5831..ea47b0e65802 (9 commits) (flutter/engine#14481) * 35adf37 [web] Implement Paragraph.getLineBoundary (flutter/engine#14479) * 00cbfd3 [web] Remove Paragraph._lines which isn't necessary anymore (flutter/engine#14485) * d6172fd libtxt: cache fallback fonts found by a Minikin font collection (flutter/engine#14482) * 1912478 adding firefox unit tests to font loading (flutter/engine#14487) * 6c71f89 Introduce an auto-deletable SkiaObject; make SkPaint a SkiaObject (flutter/engine#14486) * 2026b83 Roll src/third_party/dart 8ad8abfb7463..83eeab1e63d9 (13 commits) (flutter/engine#14488) * b43d3fe Roll src/third_party/skia ea47b0e65802..cd9ad409a90d (7 commits) (flutter/engine#14490) * 3c85b82 Roll fuchsia/sdk/core/linux-amd64 from QZVxo... to q0tup... (flutter/engine#14494) * 3e3eb9c Roll src/third_party/dart 83eeab1e63d9..6c99171686be (5 commits) (flutter/engine#14492) * cbe0e6c Roll src/third_party/skia cd9ad409a90d..cf0e3c63fd22 (1 commits) (flutter/engine#14495) * a653bd8 Roll fuchsia/sdk/core/mac-amd64 from 5t09i... to esDH2... (flutter/engine#14493) * 17d8882 Roll src/third_party/dart 6c99171686be..09a0b040dd9b (1 commits) (flutter/engine#14497) * be9c7c9 Roll src/third_party/skia cf0e3c63fd22..9e7199561fc8 (1 commits) (flutter/engine#14499) * c504b8f Roll src/third_party/skia 9e7199561fc8..ef363a9ce692 (1 commits) (flutter/engine#14500) * cf20f87 Roll src/third_party/dart 09a0b040dd9b..ae3973da4023 (1 commits) (flutter/engine#14501) * bb3166b Roll src/third_party/dart ae3973da4023..24b99838f433 (3 commits) (flutter/engine#14502) * 87c1110 Roll src/third_party/skia ef363a9ce692..187cd367d388 (1 commits) (flutter/engine#14503) * 45c6c3a Roll src/third_party/skia 187cd367d388..706eb5788e8b (1 commits) (flutter/engine#14505) * d292380 Fix comments of iOS status bar height constant (flutter/engine#14496) * 1ed7247 Roll src/third_party/dart 24b99838f433..2e1dd98e5e7f (1 commits) (flutter/engine#14507) * 8712461 Allow custom embedders to post low memory notifications. (flutter/engine#14506) * 1d1eae2 Roll fuchsia/sdk/core/linux-amd64 from q0tup... to O6ELR... (flutter/engine#14512) * 8b47886 Roll src/third_party/dart c5c469088697..44ba80053396 (1 commits) (flutter/engine#14510) * ca799fa Roll src/third_party/skia 706eb5788e8b..9b59953e77b9 (3 commits) (flutter/engine#14511) * 8456411 Roll src/third_party/dart 44ba80053396..2eba06d26f71 (32 commits) (flutter/engine#14515) * 46d76eb Roll src/third_party/skia 9b59953e77b9..d78a9b45b9e5 (23 commits) (flutter/engine#14516) * 5f9e558 Forward low memory notifications from the shell to DartVM. (flutter/engine#14517) * dc59758 Apply SmoothPointerDataDispatcher to Fuchsia (flutter/engine#14514) * 9556f2c Roll src/third_party/dart 2eba06d26f71..b1afe2d0ebc1 (6 commits) (flutter/engine#14523) * e829384 Roll fuchsia/sdk/core/linux-amd64 from O6ELR... to ZHhOi... (flutter/engine#14525) * 0fbdeb8 Roll src/third_party/dart b1afe2d0ebc1..2d332ee1d3f1 (1 commits) (flutter/engine#14526) * 500f9ce Roll src/third_party/skia 6153165d78f2..fdb2b7d53038 (2 commits) (flutter/engine#14528)
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
This is a non-breaking addition to the stable Flutter Embedder API.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-breaking addition to the stable Flutter Embedder API.
xref b/144232910