Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added autofill functionality #16227

Closed

Conversation

ganttastic
Copy link

This PR adds autofill functionality to the engine.

iOS - functionally complete, but has a bug where autofill only shows for non-default keyboards.
Android - still needs work and guidance. Current work could be removed if only iOS implementation is wanted in this PR.
Web - not started

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ganttastic
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ganttastic ganttastic changed the title Added autofill functionality [WIP] Added autofill functionality Jan 30, 2020
String autofillHintValue = configuration.textContentType.rawValue;
if (autofillHintValue != null) {
String[] autofillHints = {autofillHintValue};
view.setAutofillHints(autofillHints);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if this is the correct view to set the auto fill hints on.

@isaiahtaylorhh
Copy link

Hello, thanks for your work on this! I'd like to cast my vote in favor of getting this accepted with the iOS capability only and opening a separate PR for the other channels. Unless there is a near timeline for the whole thing being complete. Thank you!

@ganttastic
Copy link
Author

Full autofill implementation is in PR #17493.

@ganttastic ganttastic closed this Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants