-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Added autofill functionality #16227
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
shell/platform/android/io/flutter/embedding/engine/systemchannels/TextInputChannel.java
Outdated
Show resolved
Hide resolved
String autofillHintValue = configuration.textContentType.rawValue; | ||
if (autofillHintValue != null) { | ||
String[] autofillHints = {autofillHintValue}; | ||
view.setAutofillHints(autofillHints); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure if this is the correct view to set the auto fill hints on.
Hello, thanks for your work on this! I'd like to cast my vote in favor of getting this accepted with the iOS capability only and opening a separate PR for the other channels. Unless there is a near timeline for the whole thing being complete. Thank you! |
Full autofill implementation is in PR #17493. |
This PR adds autofill functionality to the engine.
iOS - functionally complete, but has a bug where autofill only shows for non-default keyboards.
Android - still needs work and guidance. Current work could be removed if only iOS implementation is wanted in this PR.
Web - not started