Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix OOL def for dart_isolate_runner #16941

Merged
merged 2 commits into from
Mar 4, 2020
Merged

fix OOL def for dart_isolate_runner #16941

merged 2 commits into from
Mar 4, 2020

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Mar 4, 2020

Follow up to comments on #16933

@dnfield dnfield requested a review from chinmaygarde March 4, 2020 20:01
@auto-assign auto-assign bot requested a review from gaaclarke March 4, 2020 20:01
@dnfield dnfield mentioned this pull request Mar 4, 2020
Merged
chinmaygarde
chinmaygarde approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dnfield dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 4, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 4, 2020
@dnfield
Copy link
Contributor Author

dnfield commented Mar 4, 2020

Fuchsia failure is a flake.

@dnfield dnfield merged commit 4a2273e into flutter:master Mar 4, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2020
@engine-flutter-autoroll
4a2273e fix OOL def for dart_isolate_runner (flutter/engine#16941)
89fb5a2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnfield @fluttergithubbot @chinmaygarde @googlebot