Support EventChannel C++ plugin API for Linux/Windows #17015

Kurun-pan · 2020-03-08T10:25:59Z

Tested on Linux desktop environment
CI unit test wrote code, but it has not been confirmed

… app startup.

googlebot · 2020-03-08T10:26:05Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-03-08T10:26:05Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Kurun-pan · 2020-03-08T10:29:56Z

@googlebot I signed it!

googlebot · 2020-03-08T10:30:02Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot · 2020-03-08T10:30:03Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

https://github.com/flutter/engine/pull/17015/checks?check_run_id=493248665

https://github.com/flutter/engine/pull/17015/checks?check_run_id=493248658

https://github.com/flutter/engine/pull/17015/checks?check_run_id=494856201

https://github.com/flutter/engine/pull/17015/checks?check_run_id=494856238

https://github.com/flutter/engine/pull/17015/checks?check_run_id=494955839

stuartmorgan-g · 2020-03-12T18:11:41Z

shell/platform/common/cpp/client_wrapper/event_channel_unittests.cc

+      [](const uint8_t* reply, const size_t reply_size) {});
+  EXPECT_EQ(on_listen_called, true);
+
+  // FIXME: add onCancel test scenario


Please finish implementing the tests; there is commented-out code in both test methods.

I fixed unit test code.

stuartmorgan-g · 2020-03-12T18:21:06Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_channel.h

+#include "event_sink.h"
+#include "event_stream_handler.h"
+
+static constexpr char kOnListenMethod[] = "listen";


static in a header (other than in a class) is almost always a mistake; this construction can lead to ODR violations. Since we're not allowing C++17 in the wrapper yet (where you could use inline constexpr, which would be the right way to do what you are trying to do here), you need to extern these and put the values in an implementation file.

stuartmorgan-g · 2020-03-12T18:23:10Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_channel.h

+  // If no handler has been registered, any incoming stream setup requests will
+  // be handled silently by providing an empty stream.
+  void SetStreamHandler(const StreamHandler<T>& handler) const {
+    // TODO: The following is required when nullptr


I'm confused by this comment, since the argument is a const reference, not a pointer.

stuartmorgan-g · 2020-03-12T18:23:49Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_channel.h

+    // TODO: The following is required when nullptr
+    // can be passed as an argument.
+    // if (!handler) { /* <= available for more than C++17 */
+    //   messenger_->SetMessageHandler(name_, nullptr);


Without this code, what is the process for removing a handler?

There is no way. I think again.

I implemented it.

stuartmorgan-g · 2020-03-12T18:24:21Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_channel.h

+    //   return;
+    // }
+
+    const auto* codec = codec_;


Do not use auto when the type is not immediately inferable from the line of code.

stuartmorgan-g · 2020-03-12T18:53:03Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_sink.h

+
+namespace flutter {
+
+// Event callback. Supports dual use: Producers of events to be sent to Flutter


Being both called and implemented isn't really "dual use"; that's what an interface is.

I Modified comment.

stuartmorgan-g · 2020-03-12T19:42:55Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_stream_handler.h

+class StreamHandler {
+ public:
+  // Handles a request to set up an event stream.
+  // @param arguments stream configuration arguments, possibly null.


Why is this notation being used only for a subset of this one class?

I'm fine with adopting Doxygen for the client wrapper, but if it's going to be done it should be done consistently in all the new code.

I used the comments of following source code for reference. I thought the same comment would be better.
shell/platform/android/io/flutter/plugin/common/EventChannel.java

There's definitely no sense of unity in the code. Adjust to other C++ code, I try not to use Doxygen Doc comments.

shell/platform/common/cpp/client_wrapper/include/flutter/event_stream_handler.h

stuartmorgan-g · 2020-03-12T19:45:18Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_stream_handler.h

+  OnListen onListen;
+  OnCancel onCancel;
+
+  // Registers a stream handler on this channel.


This comment is copypasta.

stuartmorgan-g · 2020-03-12T19:49:53Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_channel.h

+          handler.onCancel(method_call->arguments());
+
+          auto result = codec->EncodeSuccessEnvelope();
+          uint8_t* buffer = new uint8_t[result->size()];


Note that you are leaking buffer here, demonstrating why using new/delete manually should be avoided whenever possible. (Separately from the fact that I don't think this buffer should exist in the first place.)

I deleted these codes.

Kurun-pan · 2020-04-18T23:43:45Z

@stuartmorgan

Thank you for your review.

Some comments still, but I think this is very close. Thanks for your work on this!

I'm glad to hear that! Thank you.

I'm done fixing. Could you request again?

stuartmorgan-g

Just some minor nits remaining.

stuartmorgan-g · 2020-04-27T18:58:35Z

shell/platform/common/cpp/client_wrapper/event_channel_unittests.cc

+  EXPECT_EQ(on_cancel_called, true);
+}
+
+// Test that consecutive call of OnListen.


Please fix this comment; tests that consecutive calls do what?

stuartmorgan-g · 2020-04-27T19:01:28Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_channel.h

+      const std::string& method = method_call->method_name();
+      if (method.compare(kOnListenMethod) == 0) {
+        if (is_listening_) {
+          auto error = shared_handler->OnCancel(nullptr);


Please don't use auto here; the type is non-obvious from local context.

stuartmorgan-g · 2020-04-27T19:01:42Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_channel.h

+        std::unique_ptr<std::vector<uint8_t>> result;
+        auto sink = std::make_unique<EventSinkImplementation>(
+            messenger, channel_name, codec);
+        auto error =


stuartmorgan-g · 2020-04-27T19:57:46Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_stream_handler.h

+
+// Handler of stream setup and tear-down requests.
+// Implementations must be prepared to accept sequences of alternating calls to
+// onListen() and onCancel(). Implementations should ideally consume no


Nit: OnListen and OnCancel

Applies throughout this comment, which currently uses low case initial letters everywhere.

stuartmorgan-g · 2020-04-27T20:00:05Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_stream_handler.h

+  StreamHandler& operator=(StreamHandler const&) = delete;
+
+  // Handles a request to set up an event stream. Returns error if representing
+  // an unsuccessful outcome of invoking the method, possibly nullptr.


I'm finding this sentence a bit hard to parse. How about just "Returns nullptr on success, or an error on failure."

Thank you! Modified.

stuartmorgan-g · 2020-04-27T20:00:21Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_stream_handler.h

+  }
+
+  // Handles a request to tear down the most recently created event stream.
+  // Returns error if representing an unsuccessful outcome of invoking the


Thank you! Modified.

stuartmorgan-g · 2020-04-27T20:02:40Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_stream_handler_functions.h

+    }
+
+    auto error = std::make_unique<StreamHandlerError<T>>(
+        "error", "Not found StreamHandlerListen hander", nullptr);


"No OnListen handler set"

stuartmorgan-g · 2020-04-27T20:02:52Z

shell/platform/common/cpp/client_wrapper/include/flutter/event_stream_handler_functions.h

+    }
+
+    auto error = std::make_unique<StreamHandlerError<T>>(
+        "error", "Not found StreamHandlerCancel hander", nullptr);


"No OnCancel handler set"

…se some auto variables.

…ent-channel-support-linux-windows

Kurun-pan · 2020-04-30T09:01:41Z

@stuartmorgan
Thank you for your review. I fixed. Could you check again? Thank you as always.

stuartmorgan-g

LGTM. Thanks for the contribution!

git@github.com:flutter/engine.git/compare/3953c3ccd15a...15f72b8 git log 3953c3c..15f72b8 --first-parent --oneline 2020-05-07 38722979+Kurun-pan@users.noreply.github.com Support EventChannel C++ plugin API for Linux/Windows (flutter/engine#17015) 2020-05-07 robert.ancell@canonical.com Handle leak of message handle when no engine present (flutter/engine#18157) 2020-05-07 xster@google.com add docs to platformviewios (and some drive-by changes) (flutter/engine#17593) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 0066adefa97d..c66cd987f7c0 (4 commits) (flutter/engine#18206) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia edea19858ccc..0066adefa97d (3 commits) (flutter/engine#18203) 2020-05-07 jason-simmons@users.noreply.github.com Remove the global engine entry timestamp (flutter/engine#18182) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart e86e4d61834a..ce62ad2e8b40 (13 commits) (flutter/engine#18201) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2871ab0727bf..edea19858ccc (3 commits) (flutter/engine#18198) 2020-05-07 dtiselice@google.com Fixed ChildSceneLayer elevation issue on Fuchsia. (flutter/engine#18144) 2020-05-07 iska.kaushik@gmail.com [profiling] CPU Profiling support for iOS (flutter/engine#18087) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia e3d1de7c5281..2871ab0727bf (1 commits) (flutter/engine#18197) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart 733153eb517c..e86e4d61834a (6 commits) (flutter/engine#18195) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3b2db26c59d6..e3d1de7c5281 (4 commits) (flutter/engine#18192) 2020-05-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from jMJqf... to 1MVsE... (flutter/engine#18194) 2020-05-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from RpHTv... to MhpFP... (flutter/engine#18191) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 88d04cb51acf..3b2db26c59d6 (1 commits) (flutter/engine#18190) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4da5b40fb6dc..733153eb517c (23 commits) (flutter/engine#18188) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC garyq@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

git@github.com:flutter/engine.git/compare/3953c3ccd15a...23cca32 git log 3953c3c..23cca32 --first-parent --oneline 2020-05-07 a-siva@users.noreply.github.com Manual Roll of Dart 39e0e75fcf...ce62ad2e8b (flutter/engine#18211) 2020-05-07 38722979+Kurun-pan@users.noreply.github.com Support EventChannel C++ plugin API for Linux/Windows (flutter/engine#17015) 2020-05-07 robert.ancell@canonical.com Handle leak of message handle when no engine present (flutter/engine#18157) 2020-05-07 xster@google.com add docs to platformviewios (and some drive-by changes) (flutter/engine#17593) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 0066adefa97d..c66cd987f7c0 (4 commits) (flutter/engine#18206) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia edea19858ccc..0066adefa97d (3 commits) (flutter/engine#18203) 2020-05-07 jason-simmons@users.noreply.github.com Remove the global engine entry timestamp (flutter/engine#18182) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart e86e4d61834a..ce62ad2e8b40 (13 commits) (flutter/engine#18201) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2871ab0727bf..edea19858ccc (3 commits) (flutter/engine#18198) 2020-05-07 dtiselice@google.com Fixed ChildSceneLayer elevation issue on Fuchsia. (flutter/engine#18144) 2020-05-07 iska.kaushik@gmail.com [profiling] CPU Profiling support for iOS (flutter/engine#18087) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia e3d1de7c5281..2871ab0727bf (1 commits) (flutter/engine#18197) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart 733153eb517c..e86e4d61834a (6 commits) (flutter/engine#18195) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3b2db26c59d6..e3d1de7c5281 (4 commits) (flutter/engine#18192) 2020-05-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from jMJqf... to 1MVsE... (flutter/engine#18194) 2020-05-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from RpHTv... to MhpFP... (flutter/engine#18191) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 88d04cb51acf..3b2db26c59d6 (1 commits) (flutter/engine#18190) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4da5b40fb6dc..733153eb517c (23 commits) (flutter/engine#18188) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC garyq@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

git@github.com:flutter/engine.git/compare/3953c3ccd15a...e7ee47d git log 3953c3c..e7ee47d --first-parent --oneline 2020-05-08 ferhat@gmail.com [web] Implement matrix parameter for linear gradient (flutter/engine#18208) 2020-05-08 liyuqian@google.com Reland again "Remove layer integral offset snapping flutter#17112" (flutter/engine#18160) 2020-05-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia c66cd987f7c0..0dc207f836da (5 commits) (flutter/engine#18212) 2020-05-08 stuartmorgan@google.com Refactor GLFW embedding to support headless mode (flutter/engine#18205) 2020-05-07 a-siva@users.noreply.github.com Manual Roll of Dart 39e0e75fcf...ce62ad2e8b (flutter/engine#18211) 2020-05-07 38722979+Kurun-pan@users.noreply.github.com Support EventChannel C++ plugin API for Linux/Windows (flutter/engine#17015) 2020-05-07 robert.ancell@canonical.com Handle leak of message handle when no engine present (flutter/engine#18157) 2020-05-07 xster@google.com add docs to platformviewios (and some drive-by changes) (flutter/engine#17593) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 0066adefa97d..c66cd987f7c0 (4 commits) (flutter/engine#18206) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia edea19858ccc..0066adefa97d (3 commits) (flutter/engine#18203) 2020-05-07 jason-simmons@users.noreply.github.com Remove the global engine entry timestamp (flutter/engine#18182) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart e86e4d61834a..ce62ad2e8b40 (13 commits) (flutter/engine#18201) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2871ab0727bf..edea19858ccc (3 commits) (flutter/engine#18198) 2020-05-07 dtiselice@google.com Fixed ChildSceneLayer elevation issue on Fuchsia. (flutter/engine#18144) 2020-05-07 iska.kaushik@gmail.com [profiling] CPU Profiling support for iOS (flutter/engine#18087) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia e3d1de7c5281..2871ab0727bf (1 commits) (flutter/engine#18197) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart 733153eb517c..e86e4d61834a (6 commits) (flutter/engine#18195) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3b2db26c59d6..e3d1de7c5281 (4 commits) (flutter/engine#18192) 2020-05-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from jMJqf... to 1MVsE... (flutter/engine#18194) 2020-05-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from RpHTv... to MhpFP... (flutter/engine#18191) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 88d04cb51acf..3b2db26c59d6 (1 commits) (flutter/engine#18190) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4da5b40fb6dc..733153eb517c (23 commits) (flutter/engine#18188) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC garyq@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

git@github.com:flutter/engine.git/compare/3953c3ccd15a...403931f git log 3953c3c..403931f --first-parent --oneline 2020-05-08 robert.ancell@canonical.com Add FlValue (flutter/engine#18185) 2020-05-08 jason-simmons@users.noreply.github.com [SkParagraph] Copy text height behavior to the Skia paragraph style (flutter/engine#18178) 2020-05-08 ferhat@gmail.com [web] Implement matrix parameter for linear gradient (flutter/engine#18208) 2020-05-08 liyuqian@google.com Reland again "Remove layer integral offset snapping flutter#17112" (flutter/engine#18160) 2020-05-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia c66cd987f7c0..0dc207f836da (5 commits) (flutter/engine#18212) 2020-05-08 stuartmorgan@google.com Refactor GLFW embedding to support headless mode (flutter/engine#18205) 2020-05-07 a-siva@users.noreply.github.com Manual Roll of Dart 39e0e75fcf...ce62ad2e8b (flutter/engine#18211) 2020-05-07 38722979+Kurun-pan@users.noreply.github.com Support EventChannel C++ plugin API for Linux/Windows (flutter/engine#17015) 2020-05-07 robert.ancell@canonical.com Handle leak of message handle when no engine present (flutter/engine#18157) 2020-05-07 xster@google.com add docs to platformviewios (and some drive-by changes) (flutter/engine#17593) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 0066adefa97d..c66cd987f7c0 (4 commits) (flutter/engine#18206) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia edea19858ccc..0066adefa97d (3 commits) (flutter/engine#18203) 2020-05-07 jason-simmons@users.noreply.github.com Remove the global engine entry timestamp (flutter/engine#18182) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart e86e4d61834a..ce62ad2e8b40 (13 commits) (flutter/engine#18201) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2871ab0727bf..edea19858ccc (3 commits) (flutter/engine#18198) 2020-05-07 dtiselice@google.com Fixed ChildSceneLayer elevation issue on Fuchsia. (flutter/engine#18144) 2020-05-07 iska.kaushik@gmail.com [profiling] CPU Profiling support for iOS (flutter/engine#18087) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia e3d1de7c5281..2871ab0727bf (1 commits) (flutter/engine#18197) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart 733153eb517c..e86e4d61834a (6 commits) (flutter/engine#18195) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3b2db26c59d6..e3d1de7c5281 (4 commits) (flutter/engine#18192) 2020-05-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from jMJqf... to 1MVsE... (flutter/engine#18194) 2020-05-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from RpHTv... to MhpFP... (flutter/engine#18191) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 88d04cb51acf..3b2db26c59d6 (1 commits) (flutter/engine#18190) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4da5b40fb6dc..733153eb517c (23 commits) (flutter/engine#18188) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC garyq@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

git@github.com:flutter/engine.git/compare/3953c3ccd15a...9193d8f git log 3953c3c..9193d8f --first-parent --oneline 2020-05-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 0dc207f836da..a14084ba1b41 (3 commits) (flutter/engine#18219) 2020-05-08 robert.ancell@canonical.com Add FlValue (flutter/engine#18185) 2020-05-08 jason-simmons@users.noreply.github.com [SkParagraph] Copy text height behavior to the Skia paragraph style (flutter/engine#18178) 2020-05-08 ferhat@gmail.com [web] Implement matrix parameter for linear gradient (flutter/engine#18208) 2020-05-08 liyuqian@google.com Reland again "Remove layer integral offset snapping flutter#17112" (flutter/engine#18160) 2020-05-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia c66cd987f7c0..0dc207f836da (5 commits) (flutter/engine#18212) 2020-05-08 stuartmorgan@google.com Refactor GLFW embedding to support headless mode (flutter/engine#18205) 2020-05-07 a-siva@users.noreply.github.com Manual Roll of Dart 39e0e75fcf...ce62ad2e8b (flutter/engine#18211) 2020-05-07 38722979+Kurun-pan@users.noreply.github.com Support EventChannel C++ plugin API for Linux/Windows (flutter/engine#17015) 2020-05-07 robert.ancell@canonical.com Handle leak of message handle when no engine present (flutter/engine#18157) 2020-05-07 xster@google.com add docs to platformviewios (and some drive-by changes) (flutter/engine#17593) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 0066adefa97d..c66cd987f7c0 (4 commits) (flutter/engine#18206) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia edea19858ccc..0066adefa97d (3 commits) (flutter/engine#18203) 2020-05-07 jason-simmons@users.noreply.github.com Remove the global engine entry timestamp (flutter/engine#18182) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart e86e4d61834a..ce62ad2e8b40 (13 commits) (flutter/engine#18201) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2871ab0727bf..edea19858ccc (3 commits) (flutter/engine#18198) 2020-05-07 dtiselice@google.com Fixed ChildSceneLayer elevation issue on Fuchsia. (flutter/engine#18144) 2020-05-07 iska.kaushik@gmail.com [profiling] CPU Profiling support for iOS (flutter/engine#18087) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia e3d1de7c5281..2871ab0727bf (1 commits) (flutter/engine#18197) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart 733153eb517c..e86e4d61834a (6 commits) (flutter/engine#18195) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3b2db26c59d6..e3d1de7c5281 (4 commits) (flutter/engine#18192) 2020-05-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from jMJqf... to 1MVsE... (flutter/engine#18194) 2020-05-07 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from RpHTv... to MhpFP... (flutter/engine#18191) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/skia 88d04cb51acf..3b2db26c59d6 (1 commits) (flutter/engine#18190) 2020-05-07 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4da5b40fb6dc..733153eb517c (23 commits) (flutter/engine#18188) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC garyq@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Kurun-pan · 2020-05-08T14:57:57Z

Thank you so much!

beevelop · 2020-05-11T20:42:45Z

@Kurun-pan Thank you man for the PR. Awesome stuff 🚀

Kurun-pan · 2020-05-12T00:00:34Z

@beevelop
Thank you for your message. I'm very happy to get your message.

matt-deboer · 2020-09-04T21:01:43Z

This looks exciting; are there any examples out there that leverage this API yet for a Linux plugin?

stuartmorgan-g · 2020-09-04T22:09:36Z

Linux switched to a completely different API surface several months ago, so the C++ API is now Windows-only. I've filed flutter/flutter#65270 for adding it to the new Linux API.

DlmuZQ · 2020-11-24T06:41:11Z

How do I use the event channel on windows? Can you give some example?

fawdlstty · 2021-02-20T12:05:17Z

I have try to use EventChannel, but I found memory leaks and crashes. Question and example code here: #76448

who can give some help? thanks in advance

Kurun-pan added 4 commits March 7, 2020 20:45

Initial commit

44a638b

remove std::optional (C++17)

395df1e

Fix unit test code, bugfix.

c556c7a

Fixed bug that the error of EventChannel register stream handler when…

1000496

… app startup.

auto-assign bot requested a review from flar March 8, 2020 10:26

googlebot added the cla: no label Mar 8, 2020

googlebot added cla: yes and removed cla: no labels Mar 8, 2020

Kurun-pan added 14 commits March 9, 2020 19:38

Fix coding format.

ae81b9d

https://github.com/flutter/engine/pull/17015/checks?check_run_id=493248665

Fix unit test fail.

9069e4c

https://github.com/flutter/engine/pull/17015/checks?check_run_id=493248658

Fix coding format

8e96c4f

https://github.com/flutter/engine/pull/17015/checks?check_run_id=494856201

Fix build break.

b8fe504

https://github.com/flutter/engine/pull/17015/checks?check_run_id=494856238

Fix code format

251829e

https://github.com/flutter/engine/pull/17015/checks?check_run_id=494955839

Modified unit test scenario.

4f5e051

Fix code format

b821d51

Fix code format

7c5e963

Fix code format

0b9446e

Fix build error.

6168c67

Fix code format

6917341

Fix BUILD.gn format

f870a60

Fix licenses_flutter, core_wrapper_files.gni format

f4f8634

Fix licenses_flutter, core_wrapper_files.gni format

02b3a3e

stuartmorgan-g self-requested a review March 9, 2020 17:42

chinmaygarde self-requested a review March 10, 2020 05:06

stuartmorgan-g suggested changes Mar 12, 2020

View reviewed changes

Kurun-pan added 3 commits April 18, 2020 23:52

Fix code formatting.

b36ae30

Fix code formatting.

dfb1451

Modified method name and other.

61df9ba

godofredoc mentioned this pull request Apr 18, 2020

[engine] Old PRs breaking fuchsia devices. flutter/flutter#55123

Closed

Modify comments.

090f6bf

stuartmorgan-g suggested changes Apr 27, 2020

View reviewed changes

Kurun-pan added 2 commits April 30, 2020 11:51

Fixed some comments and unit test scenario name. Furthermore, don't u…

7905db1

…se some auto variables.

Merge commit '590381a00a56fdab914eeddcbcf4430b0f763ec1' into topic-ev…

f71c8a0

…ent-channel-support-linux-windows

stuartmorgan-g approved these changes May 7, 2020

View reviewed changes

stuartmorgan-g merged commit 15f72b8 into flutter:master May 7, 2020

engine-flutter-autoroll mentioned this pull request May 7, 2020

Roll engine 3953c3ccd15a..15f72b8c0d2b (17 commits) flutter/flutter#56610

Closed

engine-flutter-autoroll mentioned this pull request May 8, 2020

Roll engine 3953c3ccd15a..23cca3211f98 (18 commits) flutter/flutter#56615

Closed

This was referenced May 8, 2020

Roll engine 3953c3ccd15a..e7ee47d917b7 (22 commits) flutter/flutter#56617

Closed

Roll engine 3953c3ccd15a..403931ff2246 (24 commits) flutter/flutter#56621

Closed

engine-flutter-autoroll mentioned this pull request May 8, 2020

Roll engine 3953c3ccd15a..9193d8ff8303 (25 commits) flutter/flutter#56626

Closed

Kurun-pan deleted the topic-event-channel-support-linux-windows branch May 8, 2020 14:57


		namespace flutter {

		// Event callback. Supports dual use: Producers of events to be sent to Flutter

Support EventChannel C++ plugin API for Linux/Windows #17015

Support EventChannel C++ plugin API for Linux/Windows #17015

Uh oh!

Conversation

Kurun-pan commented Mar 8, 2020

Uh oh!

googlebot commented Mar 8, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

googlebot commented Mar 8, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

Kurun-pan commented Mar 8, 2020

Uh oh!

googlebot commented Mar 8, 2020

Uh oh!

googlebot commented Mar 8, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kurun-pan Mar 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kurun-pan Mar 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kurun-pan commented Apr 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Kurun-pan Mar 13, 2020 •

edited

Loading

Kurun-pan Mar 13, 2020 •

edited

Loading

Kurun-pan commented Apr 18, 2020 •

edited

Loading