Clear focus if a platform view goes away #17381
Conversation
|
/cc @amirh |
| == platformViewsAccessibilityDelegate.getPlatformViewById(semanticsNodeToBeRemoved.platformViewId)) { | ||
| // If the currently focused a11y node is within a platform view that is | ||
| // getting removed: clear it's a11y focus. | ||
| sendAccessibilityEvent( |
There was a problem hiding this comment.
I'm a little concerned about sending an event on behalf of the webview (e.g my concern is that it's internal state may think that it is still focused), do you know whether this is considered safe to do?
There was a problem hiding this comment.
Unfortunately, I don't have an authoritative answer to that question :(
In my experiments it all seems to work out. E.g. when you go back to the route with the webview by popping the route above it, focus behaves reasonable.
There was a problem hiding this comment.
I'll live with that if it's the best we got 😕
The other approach I'd consider would be to see if we can make the webview send that event (e.g maybe by turning it invisible within the vd?)
|
@amirh Are there any existing tests for the a11y integration of PlatformViews I can borrow from? |
|
Unfortunately no, AFAIK there we currently have no tests for Android a11y :( |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
goderbauer
force-pushed
the
a11yfocusplatformview
branch
from
10eb6eb to
ea22916
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
A unit test has been added. PTAL @amirh |
|
The "Mac Android AOT Engine" check passed on re-run: https://ci.chromium.org/p/flutter/builders/try/Mac%20Android%20AOT%20Engine/1015 |
When a SemanticsNode with a platformViewId is removed from the SemanticsTree, we need to clear the a11y focus in the associated embedded platfromview if it had focus.
Fixes b/149886151.