This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Extract and reuse common sky/shell components on Mac and iOS #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| NSStringFromClass([SkyAppDelegate class])); | ||
| int main(int argc, const char * argv[]) { | ||
| return PlatformMacMain(argc, argv, ^(){ | ||
| return UIApplicationMain(argc, (char **)argv, nil, |
There was a problem hiding this comment.
I'm surprised you need this cast here. Is main's arg actually const?
|
lgtm, but I think we could go a couple more rounds here. It's also definitely not clear to me that you want to be an NSWindow, sublcassing NSWindow is typically wrong. You probably just want to have a normal NSWindow and be the contentView on it? |
|
Will get rid of the window subclass. Also, will try to figure out how I can get the old hooks with the formatter and linter working. |
chinmaygarde
added a commit
that referenced
this pull request
Jul 21, 2015
Extract and reuse common sky/shell components on Mac and iOS
rafaelring
pushed a commit
to rafaelring/engine
that referenced
this pull request
Nov 28, 2018
…er#177) * Replace old comment / line spacing per line * Removed extraneous whitespace found on diff. * re-enable LTO, undoing change picked up from bad merge.
rafaelring
pushed a commit
to rafaelring/engine
that referenced
this pull request
Nov 28, 2018
flutter#177)" (flutter#186) This reverts commit 9bbd435. This caused major regressions, see flutter/flutter#23678. In the future, we can check the flags individually to see which we can add without regressing our benchmarks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mac target is a work in progress. I am also in the process of extracting the test runner methods into a common file. In a separate commit.