Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@LongCatIsLooong
Copy link
Contributor

I'm not sure how I can write a test for this change, everything in the call path seems to be private.

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Maybe Gary will have an idea about testing. At least it's covered by tests in the framework if it's not possible.

@LongCatIsLooong
Copy link
Contributor Author

Hi @GaryQian what would be a test to add for this PR?

@GaryQian
Copy link
Contributor

You may be able to extend DartExecutor to log the messages it receives, and then check that a TextInputChannel constructed with this TestDartExecutor is getting sent the right success messages when requestAutofill is called. I don't think this line of testing currently exists though, so you may have to write it. Just a thought from looking at code, have not verified this way would work, though it looks like it should.

@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Apr 22, 2020

@GaryQian is there a way to send a message to a BinaryMessenger? I wanted to send a "TextInput.requestAutofill" message to the TextInputChannel and verify requestAutofill gets called, but couldn't find a way to.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants