[profiling] Memory Profiling support for iOS #18516

AlbertWang0116 · 2020-05-19T23:30:12Z

Based on Kaushik's work for iOS CPU profiling, I added the memory profiling within the same scheduled task.

The memory profiling methodologies were discussed in the internal doc. Please see go/flutter-ios-memory-profiling.

AlbertWang0116 · 2020-05-20T17:11:43Z

cc @iskakaushik @liyuqian

iskakaushik

LGTM modulo rename.

iskakaushik · 2020-05-20T17:33:26Z

shell/profiling/sampling_profiler.h

+ */
+struct MemoryUsageInfo {
+  double dirty_memory_usage;
+  double owned_share_memory_usage;


rename this to owned_shared_memory_usage.

liyuqian

I wonder if we can use the scenario_app to test this using iOS simulators, @blasten @cyanglaz ?

liyuqian · 2020-05-20T18:57:09Z

shell/profiling/sampling_profiler.h

+ * `physical memory - dirty memory`.
+ */
+struct MemoryUsageInfo {
+  double dirty_memory_usage;


Document what unit it uses (e.g., MB, KB, or something else)

Oh, I missed the "mega bytes" in the struct documentation... Maybe also put a capitalized MB there, or add a document for each field so they're more prominent.

I rephrased the docstring a bit so that "MB" should be more obvious than "mega bytes". I will keep the docstring as is so it is consistent with the CPU part.

As another way, we can also rename them to dirty_memory_usage_mb and owned_shared_memory_usage_mb, WDYT?

The MB docstring as it is now looks good!

fluttergithubbot · 2020-05-20T19:27:02Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Mac iOS Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

liyuqian · 2020-05-20T20:05:18Z

shell/platform/darwin/ios/framework/Source/profiler_metrics_ios.mm

+  const double dirty_memory_usage =
+      static_cast<float>(task_memory_info.phys_footprint) / 1024.0 / 1024.0;
+  const double owned_shared_memory_usage =
+      static_cast<float>(task_memory_info.resident_size) / 1024.0 / 1024.0 - dirty_memory_usage;


Is there any specific reason that it's casting to float first, and eventually becomes a double? Should both be float or double?

You are right, as definition this should be both double.

liyuqian · 2020-05-20T20:06:26Z

shell/profiling/sampling_profiler.h

+ * `physical memory - dirty memory`.
+ */
+struct MemoryUsageInfo {
+  double dirty_memory_usage;


The MB docstring as it is now looks good!

…18516)

Based on Kaushik's work for iOS CPU profiling, I added the memory profiling within the same scheduled task. The memory profiling methodologies were discussed in the internal doc. Please see go/flutter-ios-memory-profiling.

…18516)

Roll Engine from 9ce1e5c to 1a83498 (69 revisions) flutter/engine@9ce1e5c...1a83498 2020-05-26 hterkelsen@users.noreply.github.com Revert "Update CanvasKit to 0.15.0 (flutter#18570)" (flutter/engine#18600) 2020-05-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from TSEOq... to hr-HZ... (flutter/engine#18594) 2020-05-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 65113fd73dec to 9e3b0289197d (2 revisions) (flutter/engine#18593) 2020-05-26 skia-flutter-autoroll@skia.org Roll Skia from b6d158aaf3dd to e4b4ca1050b9 (1 revision) (flutter/engine#18592) 2020-05-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from DzG49... to pLp67... (flutter/engine#18591) 2020-05-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Oz016... to TSEOq... (flutter/engine#18590) 2020-05-23 skia-flutter-autoroll@skia.org Roll Skia from afd8a6c6ae87 to b6d158aaf3dd (3 revisions) (flutter/engine#18588) 2020-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 99Z4_... to Oz016... (flutter/engine#18582) 2020-05-22 skia-flutter-autoroll@skia.org Roll Skia from ec31488ace66 to afd8a6c6ae87 (1 revision) (flutter/engine#18581) 2020-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Kvwlr... to DzG49... (flutter/engine#18580) 2020-05-22 skia-flutter-autoroll@skia.org Roll Skia from 80abb89c3632 to ec31488ace66 (1 revision) (flutter/engine#18579) 2020-05-22 skia-flutter-autoroll@skia.org Roll Skia from da90c3765908 to 80abb89c3632 (4 revisions) (flutter/engine#18577) 2020-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from _zNmv... to 99Z4_... (flutter/engine#18576) 2020-05-22 skia-flutter-autoroll@skia.org Roll Skia from 317dce5c81c0 to da90c3765908 (1 revision) (flutter/engine#18575) 2020-05-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 4ee57c08e0a6 to 65113fd73dec (3 revisions) (flutter/engine#18574) 2020-05-22 skia-flutter-autoroll@skia.org Roll Skia from 67e21a19259b to 317dce5c81c0 (3 revisions) (flutter/engine#18573) 2020-05-22 hterkelsen@users.noreply.github.com Update CanvasKit to 0.15.0 (flutter/engine#18570) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from 3d52abc84667 to 67e21a19259b (1 revision) (flutter/engine#18568) 2020-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 396b5fb7a97d to 4ee57c08e0a6 (6 revisions) (flutter/engine#18567) 2020-05-21 robert.ancell@canonical.com Add fl_value_to_string (flutter/engine#18540) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from 1e63279156d6 to 3d52abc84667 (5 revisions) (flutter/engine#18566) 2020-05-21 chris@bracken.jp null-annotate semantics.dart (flutter/engine#18553) 2020-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ciqRH... to Kvwlr... (flutter/engine#18565) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from b37105ea6cca to 1e63279156d6 (9 revisions) (flutter/engine#18564) 2020-05-21 gw280@google.com Implement WriteAtomically using write/fsync on all platforms, and enable (flutter/engine#18320) 2020-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from ecce58c1e354 to 396b5fb7a97d (2 revisions) (flutter/engine#18560) 2020-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from RNByJ... to _zNmv... (flutter/engine#18558) 2020-05-21 st.krwlng@gmail.com [profiling] Memory Profiling support for iOS (flutter/engine#18516) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from 22636205ce92 to b37105ea6cca (2 revisions) (flutter/engine#18557) 2020-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from d551980ac9fc to ecce58c1e354 (2 revisions) (flutter/engine#18556) 2020-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from bf7e9d13d730 to d551980ac9fc (6 revisions) (flutter/engine#18551) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from 4c0578632217 to 22636205ce92 (4 revisions) (flutter/engine#18550) 2020-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ThMeW... to ciqRH... (flutter/engine#18549) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from 67ff541ac116 to 4c0578632217 (1 revision) (flutter/engine#18547) 2020-05-21 xster@google.com Let run_tests.py just stream output (flutter/engine#18534) 2020-05-21 robert.ancell@canonical.com Add FlKeyEventPlugin (flutter/engine#18313) 2020-05-21 mehmetf@users.noreply.github.com Add tests for StandardMethodCodec (flutter/engine#18521) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from f83baf230c69 to 67ff541ac116 (1 revision) (flutter/engine#18545) 2020-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 3o9aQ... to RNByJ... (flutter/engine#18543) 2020-05-21 dworsham@google.com fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492) 2020-05-21 skia-flutter-autoroll@skia.org Roll Skia from d2dc8ddcdf5e to f83baf230c69 (2 revisions) (flutter/engine#18539) 2020-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 7aa8656d1dd8 to bf7e9d13d730 (21 revisions) (flutter/engine#18538) 2020-05-21 robert.ancell@canonical.com Add FlMethodChannel, FlMethodCodec, FlStandardMethodCodec and FlJsonMethodCodec (flutter/engine#18220) 2020-05-20 ferhat@gmail.com [web] Fix arc rendering when it starts a new sub path. (flutter/engine#18535) 2020-05-20 garyq@google.com Send platformResolvedLocale from iOS embedder (flutter/engine#18519) 2020-05-20 dkwingsmt@users.noreply.github.com System mouse cursor: macOS (flutter/engine#18131) ...

liyuqian · 2020-05-29T22:58:06Z

@terrylucas , the Flutter engine now reports iOS memory usage in tracing events (we could also add Android usages in the future so we don't have to rely on adb). Do you think this would be useful for DevTools? Also CC @cobblest @dnfield

AlbertWang0116 added 2 commits May 19, 2020 15:53

Add iOS memory profiling to Flutter profiling.

f6b1431

Adjust docstrings.

bb431f0

googlebot added the cla: yes label May 19, 2020

format.

26c2e9a

AlbertWang0116 marked this pull request as ready for review May 20, 2020 17:10

auto-assign bot requested a review from jason-simmons May 20, 2020 17:11

iskakaushik self-requested a review May 20, 2020 17:18

iskakaushik approved these changes May 20, 2020

View reviewed changes

Module renaming: owned_share_memory_usage -> owned_shared_memory_usage.

1b8a3dd

iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 20, 2020

liyuqian reviewed May 20, 2020

View reviewed changes

fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 20, 2020

Empahsize "MB" in docstring.

338ee30

liyuqian reviewed May 20, 2020

View reviewed changes

float -> double for type consistency.

1c8445f

iskakaushik merged commit 2187523 into flutter:master May 21, 2020

engine-flutter-autoroll mentioned this pull request May 21, 2020

Roll Engine from 9ce1e5c5c7e7 to ec8c9b0e01b7 (44 revisions) flutter/flutter#57757

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2020

2187523 [profiling] Memory Profiling support for iOS (flutter/engine#…

ff2df5d

…18516)

engine-flutter-autoroll mentioned this pull request May 21, 2020

Roll Engine from 9ce1e5c5c7e7 to 9f4468602cb3 (48 revisions) flutter/flutter#57765

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2020

2187523 [profiling] Memory Profiling support for iOS (flutter/engine#…

87d0daa

…18516)

engine-flutter-autoroll mentioned this pull request May 22, 2020

Roll Engine from 9ce1e5c5c7e7 to c1c7ab96aa2b (49 revisions) flutter/flutter#57769

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020

2187523 [profiling] Memory Profiling support for iOS (flutter/engine#…

a443be9

…18516)

engine-flutter-autoroll mentioned this pull request May 22, 2020

Roll Engine from 9ce1e5c5c7e7 to 89abc38a159a (51 revisions) flutter/flutter#57771

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020

2187523 [profiling] Memory Profiling support for iOS (flutter/engine#…

c57ad39

…18516)

engine-flutter-autoroll mentioned this pull request May 22, 2020

Roll Engine from 9ce1e5c5c7e7 to c5a30b945515 (55 revisions) flutter/flutter#57785

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020

2187523 [profiling] Memory Profiling support for iOS (flutter/engine#…

a5d2f8d

…18516)

engine-flutter-autoroll mentioned this pull request May 22, 2020

Roll Engine from 9ce1e5c5c7e7 to d0429b865b4b (56 revisions) flutter/flutter#57790

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020

2187523 [profiling] Memory Profiling support for iOS (flutter/engine#…

1102dbc

…18516)

engine-flutter-autoroll mentioned this pull request May 22, 2020

Roll Engine from 9ce1e5c5c7e7 to 29d31f6e507c (60 revisions) flutter/flutter#57816

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020

2187523 [profiling] Memory Profiling support for iOS (flutter/engine#…

af8089a

…18516)

engine-flutter-autoroll mentioned this pull request May 22, 2020

Roll Engine from 9ce1e5c5c7e7 to 660b48d08048 (61 revisions) flutter/flutter#57820

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020

2187523 [profiling] Memory Profiling support for iOS (flutter/engine#…

f429804

…18516)

engine-flutter-autoroll mentioned this pull request May 23, 2020

Roll Engine from 9ce1e5c5c7e7 to 42bac718f814 (63 revisions) flutter/flutter#57861

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2020

2187523 [profiling] Memory Profiling support for iOS (flutter/engine#…

d54e408

…18516)

engine-flutter-autoroll mentioned this pull request May 26, 2020

Roll Engine from 9ce1e5c5c7e7 to cd5f4983e538 (64 revisions) flutter/flutter#58009

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020

2187523 [profiling] Memory Profiling support for iOS (flutter/engine#…

e285c9b

…18516)

engine-flutter-autoroll mentioned this pull request May 26, 2020

Roll Engine from 9ce1e5c5c7e7 to fb0b82bdc63f (66 revisions) flutter/flutter#58021

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020

2187523 [profiling] Memory Profiling support for iOS (flutter/engine#…

a969c82

…18516)

engine-flutter-autoroll mentioned this pull request May 26, 2020

Roll Engine from 9ce1e5c5c7e7 to b76ce04d0848 (67 revisions) flutter/flutter#58025

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020

2187523 [profiling] Memory Profiling support for iOS (flutter/engine#…

490867c

…18516)

engine-flutter-autoroll mentioned this pull request May 26, 2020

Roll Engine from 9ce1e5c5c7e7 to 1a8349888e97 (69 revisions) flutter/flutter#58031

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020

2187523 [profiling] Memory Profiling support for iOS (flutter/engine#…

3401bf3

…18516)

This was referenced May 26, 2020

Roll Engine from 9ce1e5c5c7e7 to 1a8349888e97 (69 revisions) flutter/flutter#58041

Closed

Try measure GPU percentage using IOKit flutter/flutter#58197

Closed

liyuqian added perf: memory Performance issues related to memory severe: performance Relates to speed or footprint issues. labels May 29, 2020

iskakaushik mentioned this pull request Jun 5, 2020

Timeline summary should contain CPU/GPU and memory usage flutter/flutter#58803

Closed

AlbertWang0116 mentioned this pull request Jul 15, 2020

Adding implementation for Android CPU/GPU/Memory profiling flutter/flutter#61567

Closed

liyuqian mentioned this pull request Aug 10, 2020

Make iOS CPU/GPU measurement tool work for Xcode 11+ and iOS 13+ flutter/flutter#45435

Closed

This was referenced Aug 21, 2020

Make large jumpTo recommend deferred loading flutter/flutter#64271

Merged

Memory benchmark for showing large images in succession flutter/flutter#64762

Merged

jmagman mentioned this pull request Feb 8, 2023

Regression in average_gpu_usage in simple_animation_perf_ios flutter/flutter#120207

Closed

[profiling] Memory Profiling support for iOS #18516

[profiling] Memory Profiling support for iOS #18516

Uh oh!

Conversation

AlbertWang0116 commented May 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlbertWang0116 commented May 20, 2020

Uh oh!

iskakaushik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liyuqian left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fluttergithubbot commented May 20, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liyuqian commented May 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AlbertWang0116 commented May 19, 2020 •

edited

Loading