Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Move OnDisplayPlatformView JNI call #19258

Merged
blasten merged 1 commit into from
Jun 24, 2020
Merged

Move OnDisplayPlatformView JNI call #19258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions shell/platform/android/external_view_embedder/external_view_embedder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,16 +91,6 @@ bool AndroidExternalViewEmbedder::SubmitFrame(

for (size_t i = 0; i < composition_order_.size(); i++) {
int64_t view_id = composition_order_[i];
SkRect view_rect = GetViewRect(view_id);

// Display the platform view. If it's already displayed, then it's
// just positioned and sized.
jni_facade_->FlutterViewOnDisplayPlatformView(view_id, //
view_rect.x(), //
view_rect.y(), //
view_rect.width(), //
view_rect.height() //
);

sk_sp<SkPicture> picture =
picture_recorders_.at(view_id)->finishRecordingAsPicture();
Expand Down Expand Up @@ -156,6 +146,15 @@ bool AndroidExternalViewEmbedder::SubmitFrame(
frame->Submit();

for (int64_t view_id : composition_order_) {
SkRect view_rect = GetViewRect(view_id);
// Display the platform view. If it's already displayed, then it's
// just positioned and sized.
jni_facade_->FlutterViewOnDisplayPlatformView(view_id, //
view_rect.x(), //
view_rect.y(), //
view_rect.width(), //
view_rect.height() //
);
for (const SkRect& overlay_rect : overlay_layers.at(view_id)) {
CreateSurfaceIfNeeded(context, //
view_id, //
Expand Down