This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Initial work toward converting the FlutterView to use a FlutterImageView on demand #19279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
blasten
reviewed
Jun 24, 2020
| final int desiredHeight = currentImage.getHeight(); | ||
|
|
||
| currentBitmap = | ||
| android.graphics.Bitmap.createBitmap( |
There was a problem hiding this comment.
nit: Bitmap.createBitmap
Feel free to address this later: The Android team suggested to reuse the bitmap.
Member
Author
There was a problem hiding this comment.
Done. Also added a check to reallocate the bitmap only if its dimensions are changing.
blasten
reviewed
Jun 24, 2020
| } | ||
|
|
||
| /** | ||
| * Invoked by the owner of this {@code FlutterTextureView} when it no longer wants to render a |
There was a problem hiding this comment.
nit: FlutterImageView here and below
jason-simmons
force-pushed
the
hybrid_convert_image_view
branch
from
b33dd4b to
43e2956
Compare
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Jun 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 25, 2020
…erImageView on demand (flutter/engine#19279)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.