Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix targets param in build_fuchsia_artifacts #19794

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Fix targets param in build_fuchsia_artifacts #19794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions tools/fuchsia/build_fuchsia_artifacts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,15 +221,7 @@ def GetRunnerTarget(runner_type, product, aot):
target += 'runner'
return base + target


def GetTargetsToBuild(product=False, additional_targets=[]):
targets_to_build = [
'flutter/shell/platform/fuchsia:fuchsia',
] + additional_targets
return targets_to_build


def BuildTarget(runtime_mode, arch, product, enable_lto, additional_targets=[]):
def BuildTarget(runtime_mode, arch, enable_lto, additional_targets=[]):
out_dir = 'fuchsia_%s_%s' % (runtime_mode, arch)
flags = [
'--fuchsia',
Expand All @@ -243,7 +235,7 @@ def BuildTarget(runtime_mode, arch, product, enable_lto, additional_targets=[]):
flags.append('--no-lto')

RunGN(out_dir, flags)
BuildNinjaTargets(out_dir, GetTargetsToBuild(product))
BuildNinjaTargets(out_dir, [ 'flutter' ] + additional_targets)

return

Expand Down Expand Up @@ -305,8 +297,7 @@ def main():
product = product_modes[i]
if build_mode == 'all' or runtime_mode == build_mode:
if not args.skip_build:
BuildTarget(runtime_mode, arch, product, enable_lto,
args.targets.split(","))
BuildTarget(runtime_mode, arch, enable_lto, args.targets.split(","))
BuildBucket(runtime_mode, arch, product)

if args.upload:
Expand Down