Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@nturgut
Copy link
Contributor

@nturgut nturgut commented Jul 27, 2020

Integration tests are using flutter and engine repo at the same time. Since both trees are red now, I'll pause these tests until we resolve issue: flutter/flutter#62146

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@auto-assign auto-assign bot requested a review from iskakaushik July 27, 2020 17:23
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert
Copy link
Contributor

Does this alleviate problems, or mask them?

@christopherfujino
Copy link
Contributor

Does this alleviate problems, or mask them?

it doesn't alleviate problems, but this is a chicken and the egg situation, where one tree is blocking the other.

@nturgut
Copy link
Contributor Author

nturgut commented Jul 27, 2020

Does this alleviate problems, or mask them?

Mask. It just gives us less things to worry for now. We can try to go this in this order: would be, fix the engine, roll to flutter. Fix Flutter then re-open integration tests.

@tvolkert
Copy link
Contributor

Does this alleviate problems, or mask them?

it doesn't alleviate problems, but this is a chicken and the egg situation, where one tree is blocking the other.

Gotcha - thx 👍

@nturgut
Copy link
Contributor Author

nturgut commented Jul 27, 2020

All web LUCI builds passed merging the PR. (Cirrus CI fails and it's expected)

@christopherfujino
Copy link
Contributor

All web LUCI builds passed merging the PR. (Cirrus CI fails and it's expected)

awesome. i'm rebasing #20018 now

@nturgut nturgut merged commit f27729e into flutter:master Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants