Fixes issues with invalidating matrix for SpriteBox & adds HUD to demo game #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| GameDemoWorld(App app, this._navigator, ImageMap images, this._spriteSheet, this._spriteSheetUI) : super(new Size(_gameSizeWidth, _gameSizeHeight)) { |
There was a problem hiding this comment.
constructors should come first, then fields
|
Should have left a note, but the code in game_demo_world.dart is like my playground and mostly for testing. Will clean everything up when it's more complete. Fixing formatting in the framework. |
vlidholt
added a commit
that referenced
this pull request
Jul 22, 2015
Fixes issues with invalidating matrix for SpriteBox & adds HUD to demo game
|
We're now getting people looking at this code and starting to write their own code based on it. We should strive to make sure that anything that's committed into the repository shows best practices, because people will copy-and-paste it and once it's out there, there's no going back. So if possible, clean as you go. :-) |
aam
added a commit
to aam/engine
that referenced
this pull request
Dec 28, 2018
``` 67befc4 Fix script so it assumes some default values for host_os, host_cpu vars. (flutter#204) 262d978 Android readme (flutter#202) ```
aam
added a commit
that referenced
this pull request
Dec 28, 2018
JediBurrell
pushed a commit
to JediBurrell/engine
that referenced
this pull request
Jan 10, 2019
* readme for Android SDK/NDK updates
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
* Add more words to the Dart reserved names list. * Fix explicit default to null values throughout protobuf code.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
* Bump API patch number and header version number to 7 for this
update.
Github Issues:
* Fix slink:VkSpecializationMapEntry example to avoid C/C++ strict
aliasing issues (public issue 14).
* Clarify the meaning of "matching" in flink:vkCmdBindDescriptorSets
validity language (public issue 33).
* Add stub reference pages so xrefs to not-yet-written pages don't
generate 404 errors. However, the actual content of these pages
still needs to be filled in as time allows (public issue 44, but
does not close that issue out).
* Remove incorrect validity statement for
flink:vkGetImageSparseMemoryRequirements (public issue 85).
* Reword the
<<features-limits-bufferImageGranularity,bufferImageGranularity>>
feature in terms of "aliasing", and clarify that it applies to
bindings in the same memory object (public issue 90).
* Clarify the relationship of the slink:VkPhysicalDeviceLimits
pname:maxViewportDimensions and pname:viewportBoundsRange limits
(public issue 92).
* Specify sparse unbound texture replacement in the
<<textures-texel-replacement,Texel Replacement>> section
independently of robust buffer access language (public issue 100).
* Add the <<fundamentals-architecture-model,Architecture Model>>
section to explain architecture constraints Vulkan has chosen to
accept in order to enable portable and performant code (public issue
122).
* State that an object must not be destroyed until *all* (not *any*)
uses of that object have completed (public issue 123).
* Minor editorial cleanup (public issues 129, 134, 146, 148).
* Add validity language for layer and extension names to
slink:VkDeviceCreateInfo matching that used for
slink:VkInstanceCreateInfo (public issue 130).
* Clean up terminology for the case when the bits set in one bitmask
are a subset of the bits set in another bitmask (public issue 138).
* Document that input attachments are UniformConstant not Input, in
the <<interfaces-inputattachment,Fragment Input Attachment
Interface>> section (public glslang bug 169).
Internal Issues:
* Add max enum values to "flag bits" enums (internal issue flutter#136).
* Clarify language around the various uses of the term "block" in the
<<appendix-compressedtex-bc,Block Compressed Image Formats>> section
(internal issue flutter#202).
* Removed "expand" dependency from <enums> groups in vk.xml and added
auto-generation code in the scripts to infer it instead, to ensure
consistency. This caused renaming of sname:VkColorSpaceKHR and
sname:VkPresentModeKHR etext:BEGIN_RANGE (etc.) tokens, but those
tokens are metadata, not part of the API, and the Vulkan WG is OK
with this change. This change adds ranges to two additional enums
that were missing them due to not defining the "expand" attribute
(internal issue 217).
* Tweak makefile to generate ref page nroff (.3) files in the right
output directory, working around an a2x limitation (internal issue
223).
Other Commits:
* Add validity requirements for flink:vkCmdCopyQueryPoolResults
pname:dstBuffer parameter.
* Fix ref page build to generate .3 targets in the right output
directory.
swift-kim
referenced
this pull request
in swift-kim/engine
Nov 12, 2021
* Casting a signed value which has type 'int' to a bigger unsigned integer type 'size_t' while initializing a variable * Assignment of a signed value which has type 'int32_t' to a variable of a bigger integer type 'size_t' * Uninitialized field Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim
referenced
this pull request
in swift-kim/engine
Nov 15, 2021
* Casting a signed value which has type 'int' to a bigger unsigned integer type 'size_t' while initializing a variable * Assignment of a signed value which has type 'int32_t' to a variable of a bigger integer type 'size_t' * Uninitialized field Signed-off-by: MuHong Byun <mh.byun@samsung.com>
WonyoungChoi
pushed a commit
to WonyoungChoi/engine
that referenced
this pull request
Dec 14, 2021
* Casting a signed value which has type 'int' to a bigger unsigned integer type 'size_t' while initializing a variable * Assignment of a signed value which has type 'int32_t' to a variable of a bigger integer type 'size_t' * Uninitialized field Signed-off-by: MuHong Byun <mh.byun@samsung.com>
WonyoungChoi
pushed a commit
to WonyoungChoi/engine
that referenced
this pull request
Dec 23, 2021
* Casting a signed value which has type 'int' to a bigger unsigned integer type 'size_t' while initializing a variable * Assignment of a signed value which has type 'int32_t' to a variable of a bigger integer type 'size_t' * Uninitialized field Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in SpriteBox where the visibleArea and transformMatrix properties wasn't always correctly updated.
Adds HUD to demo game