Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine 1.20.2 cherrypicks #20446

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Engine 1.20.2 cherrypicks #20446

merged 3 commits into from
Aug 13, 2020

Conversation

pcsosinski
Copy link

@pcsosinski pcsosinski commented Aug 12, 2020 •
edited
Loading

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@pcsosinski pcsosinski changed the title Engine 1.21.2 cherrypicks Engine 1.20.2 cherrypicks Aug 12, 2020
@auto-assign auto-assign bot requested a review from flar August 12, 2020 16:03
@pcsosinski pcsosinski requested review from cyanglaz and christopherfujino and removed request for flar August 12, 2020 17:39
@pcsosinski
Copy link
Author

format_and_dart_test failure is expected on 1.20 (still)

@cyanglaz
Copy link
Contributor

The Mac iOS engine screenshot test failure looks suspicious. I'm going to give it a try locally.

@pcsosinski
Copy link
Author

@cyanglaz any update?

@cyanglaz
Copy link
Contributor

The image comparison logic failed in this PR because 91f80ef is not in 1.20, which fixes the image diff logic in the scenario app.
@pcsosinski
To land this cp with passing CI we will need to include 91f80ef

@gaaclarke
Moved to RMSE for image comparison to account for slight variations i…
2570e69 
…n golden image tests (flutter#19658)

Moved to RMSE for image comparison to account for slight variations in golden image production.  (also fixed a flakey test)
cyanglaz
cyanglaz approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

christopherfujino
christopherfujino approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcsosinski pcsosinski merged commit 9d5b217 into flutter:flutter-1.20-candidate.7 Aug 13, 2020
@pcsosinski pcsosinski deleted the flutter-1.20-candidate.7 branch August 13, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@cyanglaz cyanglaz cyanglaz approved these changes

Assignees
No one assigned
Labels
cla: yes platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pcsosinski @cyanglaz @christopherfujino @googlebot @gaaclarke