Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick fix for ForwardingGestureRecognizer 1c13abaab120d8d2d4c07e5b5fc75100f56a89e2 #20730

Closed

Conversation

cyanglaz
Copy link
Contributor

This is a cherry-pick of 1c13aba

…tformViewsController` so it can access `FlutterViewController` when its available (flutter#20708)
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@cyanglaz cyanglaz changed the base branch from master to flutter-1.20-candidate.7 August 24, 2020 20:16
@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-1.20-candidate.7 to master August 24, 2020 20:16
@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@cyanglaz cyanglaz changed the base branch from master to flutter-1.20-candidate.7 August 24, 2020 20:17
@auto-assign auto-assign bot requested a review from jason-simmons August 24, 2020 20:19
@cyanglaz
Copy link
Contributor Author

Close in favor of #20797

@cyanglaz cyanglaz closed this Aug 26, 2020
@christopherfujino
Copy link
Member

Note, my PR is for beta channel. Once I get that release done, I'm gonna work on stable, so I'll probably use this PR.

@christopherfujino
Copy link
Member

Note, my PR is for beta channel. Once I get that release done, I'm gonna work on stable, so I'll probably use this PR.

Never mind, ended up just cherry-picking the commit into my own PR. Thanks for opening this though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants