-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EGL_BAD_SURFACE when app is paused #20735
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
What are the blockers to having a regression test for this? |
@zanderso we would need an emulator with this specific version of Android. I wired up the emulators on LUCI and it’s relatively easy to add a new emulator. Then, the scenario app activity could be launched, paused and resumed. |
* update dart revision * Fix EGL_BAD_SURFACE when app is paused (#20735) * The `ForwardingGestureRecognizers` to have back reference to the `PlatformViewsController` so it can access `FlutterViewController` when its available (#20708) * Remove image sizes from Picture::GetAllocationSize (#20673) * update licenses golden Co-authored-by: Emmanuel Garcia <egarciad@google.com> Co-authored-by: Chris Yang <ychris@google.com> Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com>
* Update 1.20 engine to use Dart 2.9.2 * update license goldens * Fix EGL_BAD_SURFACE when app is paused (#20735) * The `ForwardingGestureRecognizers` to have back reference to the `PlatformViewsController` so it can access `FlutterViewController` when its available (#20708) * cherry-pick e09af86 * skip linting since this was enabled in CI after this release branch cut commit. Co-authored-by: Emmanuel Garcia <egarciad@google.com> Co-authored-by: Chris Yang <ychris@google.com>
@christopherfujino @blasten Is this fix actually in 1.20.3? I can't see it mentioned in the notes for 1.20.3, also the diff does not show it.. |
Description
When the app is paused, the native Surface window is destroyed. Then, it's reset back when the app is resumed.
Related Issues
Fixes flutter/flutter#64414
Tests
There isn't a good way to test this at the moment.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.