This repository was archived by the owner on Feb 25, 2025. It is now read-only.
lerpDouble: add tests for NaN, infinity #20848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests for lerpDouble for cases where NaN or infinite values are passed. These tests simply specify the current behaviour.
cbracken
commented
Aug 28, 2020
| expect(lerpDouble(double.nan, double.nan, double.nan), isNaN); | ||
| }); | ||
|
|
||
| test('lerpDouble returns NaN if interpolation results in Infinity - Infinity', () { |
Member
Author
There was a problem hiding this comment.
I feel like there has to be a better way to word this, but can't think of anything great.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for
lerpDoublefor cases where NaN or infinite values are passed. These tests simply specify the current behaviour.Followup to #20778