This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use the gpu config for shell_unittests to declare SHELL_ENABLE_{GL,VULKAN} #21603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbreng
approved these changes
Oct 6, 2020
gw280
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2020
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Oct 7, 2020
flutter/engine@7e6191d...9a7b556 2020-10-06 jmccandless@google.com hasStrings Linux (flutter/engine#21388) 2020-10-06 nurhan@google.com add api_conform_test to analyze step. remove build script. (flutter/engine#21633) 2020-10-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 8q-OCkyhO... to xM2vYLfIT... (flutter/engine#21635) 2020-10-06 skia-flutter-autoroll@skia.org Roll Skia from 33b42e12ab71 to 107114dd1d6e (5 revisions) (flutter/engine#21634) 2020-10-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from HeAkKHbFY... to kr1tNtZvZ... (flutter/engine#21630) 2020-10-06 nurhan@google.com running web tests only on DEPS and web directories (flutter/engine#21613) 2020-10-06 skia-flutter-autoroll@skia.org Roll Skia from c3bdd1c597dc to 33b42e12ab71 (6 revisions) (flutter/engine#21628) 2020-10-06 gw280@google.com Use the gpu config for shell_unittests to declare SHELL_ENABLE_{GL,VULKAN} (flutter/engine#21603) 2020-10-06 stuartmorgan@google.com [linux] Allow engine flags via environment vars (flutter/engine#21497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2020
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Oct 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick cleanup PR. I moved the logic for adding
SHELL_ENABLE_{GL,VULKAN}intogpu.gniand just defraggingshell_unitteststo use this too.