Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions flutter_frontend_server/lib/server.dart
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,6 @@ Future<int> starter(
'--target=flutter',
'--track-widget-creation',
'--enable-asserts',
'--gen-bytecode',
'--bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions',
]);
compiler ??= _FlutterFrontendCompiler(
output,
Expand Down
4 changes: 0 additions & 4 deletions shell/platform/fuchsia/dart_runner/dart_runner.cc
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ const char* kDartVMArgs[] = {
"--precompilation",
#else
"--enable_mirrors=false",

// The interpreter is enabled unconditionally. If an app is built for
// debugging (that is, with no bytecode), the VM will fall back on ASTs.
"--enable_interpreter",
#endif

// No asserts in debug or release product.
Expand Down
5 changes: 0 additions & 5 deletions shell/platform/fuchsia/dart_runner/kernel/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ compile_platform("kernel_platform_files") {
args = [
"--enable-experiment=non-nullable",
"--nnbd-agnostic",

# TODO(dartbug.com/36342): enable bytecode for core libraries when performance of bytecode
# pipeline is on par with default pipeline and continuously tracked.
# "--bytecode",
"--target=dart_runner",
"dart:core",
]
Expand Down Expand Up @@ -75,7 +71,6 @@ template("create_kernel_core_snapshot") {
# TODO(FL-117): Re-enable causal async stack traces when this issue is
# addressed.
"--no_causal_async_stacks",
"--use_bytecode_compiler",
"--enable_mirrors=false",
"--deterministic",
"--snapshot_kind=core-jit",
Expand Down
11 changes: 0 additions & 11 deletions shell/platform/fuchsia/flutter/component.cc
Original file line number Diff line number Diff line change
Expand Up @@ -406,17 +406,6 @@ Application::Application(
// addressed.
settings_.dart_flags = {"--no_causal_async_stacks"};

// Disable code collection as it interferes with JIT code warmup
// by decreasing usage counters and flushing code which is still useful.
settings_.dart_flags.push_back("--no-collect_code");

if (!flutter::DartVM::IsRunningPrecompiledCode()) {
// The interpreter is enabled unconditionally in JIT mode. If an app is
// built for debugging (that is, with no bytecode), the VM will fall back on
// ASTs.
settings_.dart_flags.push_back("--enable_interpreter");
}

// Don't collect CPU samples from Dart VM C++ code.
settings_.dart_flags.push_back("--no_profile_vm");

Expand Down
5 changes: 0 additions & 5 deletions shell/platform/fuchsia/flutter/kernel/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ compile_platform("kernel_platform_files") {
args = [
"--enable-experiment=non-nullable",
"--nnbd-agnostic",

# TODO(dartbug.com/36342): enable bytecode for core libraries when performance of bytecode
# pipeline is on par with default pipeline and continuously tracked.
# "--bytecode",
"--target=flutter_runner",
"dart:core",
]
Expand Down Expand Up @@ -79,7 +75,6 @@ template("core_snapshot") {
# TODO(FL-117): Re-enable causal async stack traces when this issue is
# addressed.
"--no_causal_async_stacks",
"--use_bytecode_compiler",
"--enable_mirrors=false",
"--deterministic",
"--snapshot_kind=core-jit",
Expand Down