Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate runZoned to runZonedGuarded #22198

Merged
merged 1 commit into from
Oct 29, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/web_ui/dev/browser.dart
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ abstract class Browser {
// Don't return a Future here because there's no need for the caller to wait
// for the process to actually start. They should just wait for the HTTP
// request instead.
runZoned(() async {
runZonedGuarded(() async {
var process = await startBrowser();
_processCompleter.complete(process);

Expand Down Expand Up @@ -110,7 +110,7 @@ abstract class Browser {
}

_onExitCompleter.complete();
}, onError: (dynamic error, StackTrace stackTrace) {
}, (dynamic error, StackTrace stackTrace) {
// Ignore any errors after the browser has been closed.
if (_closed) {
return;
Expand Down