This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove GetExternalViewEmbedder from surface #22272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
// note to self, local branch |
This was referenced Nov 5, 2020
iskakaushik
force-pushed
the
surface-remove-get-external-view-embedder
branch
4 times, most recently
from
6ff9fd5 to
d6c59e0
Compare
Contributor
Author
|
This is now ready for review @gaaclarke , @chinmaygarde |
This decouples surfaces from view embedders.
iskakaushik
force-pushed
the
surface-remove-get-external-view-embedder
branch
from
d6c59e0 to
8dfe774
Compare
iskakaushik
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2020
iskakaushik
added a commit
to iskakaushik/engine
that referenced
this pull request
Nov 12, 2020
This reverts commit 5419f70.
zanderso
pushed a commit
that referenced
this pull request
Nov 12, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2020
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
This decouples surfaces from view embedders.
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
…edder (flutter#22468) * Revert "Remove GetExternalViewEmbedder from surface (flutter#22272)" This reverts commit 5419f70. * Revert "Rasterizer is initialized with an external view embedder (flutter#22405)" This reverts commit f95df42.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples surfaces from view embedders.