[web]Update @dart annotation. Change shaders to allocate smaller canvas #22481

ferhatb · 2020-11-12T23:43:26Z

Description

To align origin of shader pattern to target rect, we used to allocate large canvas(s). This PR compensates for the shader pattern origin.

Also updates engine files to 1.12.

Related Issues

Step towards addressing:
flutter/flutter#46833

Tests

Covered by golden tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the [contributor guide] and followed the process outlined there for submitting PRs.
I signed the [CLA].
I read and followed the [C++, Objective-C, Java style guides] for the engine.
I read the [tree hygiene] wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

I have submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

Breaking Change

Did any tests fail when you ran them? Please read [handling breaking changes].

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

yjbanov

yjbanov · 2020-11-13T00:01:32Z

lib/web_ui/lib/src/engine/canvas_pool.dart

    }
  }

+  /// Applys path to drawing context, preparing for fill and other operations.


nit: Applies

yjbanov · 2020-11-13T00:02:15Z

lib/web_ui/lib/src/engine/canvas_pool.dart


+  /// Applys path to drawing context, preparing for fill and other operations.
+  ///
+  /// !Don't refactor _runPath/_runPathWithOffset. Latency sensitive


nit: move the ! to the end of the sentence. Alternatively, begin with "WARNING:"

yjbanov · 2020-11-13T00:21:07Z

lib/web_ui/lib/src/engine/html/shaders/shader.dart

-        shaderBounds.left + 2 * (shaderBounds.width * (centerX - 0.5)),
-        -shaderBounds.top - 2 * (shaderBounds.height * (centerY - 0.5)));
+        2 * (shaderBounds.width * (centerX - 0.5)),
+        2 * (shaderBounds.height * (centerY - 0.5)));


nit: a trailing comma could help dartfmt do a better job

3 param function. I try to do it for lists and widget trees

…est.

…ler canvas (flutter/engine#22481)

…as (flutter#22481)

Update @Dart annotation. Change shaders to allocate smaller canvas

1a1ceac

ferhatb requested a review from yjbanov November 12, 2020 23:43

googlebot added the cla: yes label Nov 12, 2020

yjbanov approved these changes Nov 13, 2020

View reviewed changes

ferhatb added 7 commits November 12, 2020 16:32

Update comments/address review

376f5b3

Fix radial gradient x1/y1 offset

3120490

Fix radial offset

083da85

Fix radial gradient offset

6afa800

Update web sdk pubspec and analyzer version used by api_conformance t…

9932a70

…est.

Add message before running conformance tests

9442f4f

Merge remote-tracking branch 'upstream/master' into tilemode

38f6c3e

ferhatb merged commit c81a2ec into flutter:master Nov 13, 2020

gaaclarke mentioned this pull request Nov 13, 2020

Dart version check tripping up on copyright notices with local engine flutter/flutter#70498

Closed

engine-flutter-autoroll mentioned this pull request Nov 14, 2020

Roll Engine from e06f10638598 to 8bb47c544654 (5 revisions) flutter/flutter#70508

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2020

c81a2ec [web]Update @Dart annotation. Change shaders to allocate smal…

67d9430

…ler canvas (flutter/engine#22481)

engine-flutter-autoroll mentioned this pull request Nov 14, 2020

Roll Engine from e06f10638598 to 92e5a95a14cd (7 revisions) flutter/flutter#70512

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2020

c81a2ec [web]Update @Dart annotation. Change shaders to allocate smal…

0b14846

…ler canvas (flutter/engine#22481)

engine-flutter-autoroll mentioned this pull request Nov 14, 2020

Roll Engine from e06f10638598 to e4e2dc6f673b (8 revisions) flutter/flutter#70517

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2020

c81a2ec [web]Update @Dart annotation. Change shaders to allocate smal…

9e72f1a

…ler canvas (flutter/engine#22481)

engine-flutter-autoroll mentioned this pull request Nov 14, 2020

Roll Engine from e06f10638598 to 98628c3a098c (9 revisions) flutter/flutter#70519

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2020

c81a2ec [web]Update @Dart annotation. Change shaders to allocate smal…

68ce797

…ler canvas (flutter/engine#22481)

engine-flutter-autoroll mentioned this pull request Nov 14, 2020

Roll Engine from e06f10638598 to 713600985f95 (11 revisions) flutter/flutter#70524

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2020

c81a2ec [web]Update @Dart annotation. Change shaders to allocate smal…

c99415c

…ler canvas (flutter/engine#22481)

engine-flutter-autoroll mentioned this pull request Nov 14, 2020

Roll Engine from e06f10638598 to b0966e8123f6 (12 revisions) flutter/flutter#70530

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2020

c81a2ec [web]Update @Dart annotation. Change shaders to allocate smal…

53cc1ce

…ler canvas (flutter/engine#22481)

engine-flutter-autoroll mentioned this pull request Nov 14, 2020

Roll Engine from e06f10638598 to 6ea505eac428 (13 revisions) flutter/flutter#70532

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2020

c81a2ec [web]Update @Dart annotation. Change shaders to allocate smal…

0e0d025

…ler canvas (flutter/engine#22481)

engine-flutter-autoroll mentioned this pull request Nov 14, 2020

Roll Engine from e06f10638598 to b673845877b3 (14 revisions) flutter/flutter#70537

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2020

c81a2ec [web]Update @Dart annotation. Change shaders to allocate smal…

630d380

…ler canvas (flutter/engine#22481)

engine-flutter-autoroll mentioned this pull request Nov 14, 2020

Roll Engine from e06f10638598 to 5a35faf4341e (15 revisions) flutter/flutter#70538

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2020

c81a2ec [web]Update @Dart annotation. Change shaders to allocate smal…

632617c

…ler canvas (flutter/engine#22481)

engine-flutter-autoroll mentioned this pull request Nov 14, 2020

Roll Engine from e06f10638598 to e91aa1111d33 (16 revisions) flutter/flutter#70540

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2020

c81a2ec [web]Update @Dart annotation. Change shaders to allocate smal…

1174127

…ler canvas (flutter/engine#22481)

engine-flutter-autoroll mentioned this pull request Nov 15, 2020

Roll Engine from e06f10638598 to 3e77d854a7cb (18 revisions) flutter/flutter#70554

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2020

c81a2ec [web]Update @Dart annotation. Change shaders to allocate smal…

59489b9

…ler canvas (flutter/engine#22481)

chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020

[web]Update @Dart annotation. Change shaders to allocate smaller canv…

673db77

…as (flutter#22481)

ferhatb deleted the tilemode branch February 11, 2021 17:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[web]Update @dart annotation. Change shaders to allocate smaller canvas #22481

[web]Update @dart annotation. Change shaders to allocate smaller canvas #22481

Uh oh!

ferhatb commented Nov 12, 2020

Uh oh!

yjbanov left a comment

Uh oh!

yjbanov Nov 13, 2020

Uh oh!

ferhatb Nov 13, 2020

Uh oh!

yjbanov Nov 13, 2020

Uh oh!

ferhatb Nov 13, 2020

Uh oh!

yjbanov Nov 13, 2020

Uh oh!

ferhatb Nov 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[web]Update @dart annotation. Change shaders to allocate smaller canvas #22481

[web]Update @dart annotation. Change shaders to allocate smaller canvas #22481

Uh oh!

Conversation

ferhatb commented Nov 12, 2020

Description

Related Issues

Tests

Checklist

Reviewer Checklist

Breaking Change

Uh oh!

yjbanov left a comment

Choose a reason for hiding this comment

Uh oh!

yjbanov Nov 13, 2020

Choose a reason for hiding this comment

Uh oh!

ferhatb Nov 13, 2020

Choose a reason for hiding this comment

Uh oh!

yjbanov Nov 13, 2020

Choose a reason for hiding this comment

Uh oh!

ferhatb Nov 13, 2020

Choose a reason for hiding this comment

Uh oh!

yjbanov Nov 13, 2020

Choose a reason for hiding this comment

Uh oh!

ferhatb Nov 13, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants