This repository was archived by the owner on Feb 25, 2025. It is now read-only.
JNI bridge support for constructors, arrays, and strings #2254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
jason-simmons
added a commit
that referenced
this pull request
Jan 13, 2016
JNI bridge support for constructors, arrays, and strings
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Do not retry on OS specific error codes for `SocketException`. These OS error codes are not documented in the code, and they may change behavior depending on OS and architecture. Furthermore, many seemingly persistent errors such as DNS lookup failures should be retried. Finally, if we retry a `SocketException` unnecessarily this is of little impact. It means that if the user doesn't have a network connection, or tries to use a `PUB_HOSTED_URL` pointing to a non-existent pub server, then it will take a bit longer before the user is informed of the problem.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
PiperOrigin-RevId: 248759825
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.