[goma] Use depot_tools vended goma when it is present #22550
Conversation
iskakaushik
changed the title
|
This lgtm. My understanding is that there are (or will soon be) additional steps needed to make goma work for local builds. @godofredoc Should we be making those changes now? |
| elif args.goma and os.path.exists(goma_home_dir): | ||
| gn_args['use_goma'] = True | ||
| gn_args['goma_dir'] = goma_home_dir | ||
| elif args.goma and os.path.exists(depot_tools_bin_dir): |
There was a problem hiding this comment.
This would have to go above the args.goma case wouldn't it?
There was a problem hiding this comment.
I think this is correct. Theres 3 cases:
- Priority 1: args.goma and goma_dir is present.
- Priority 2: args.goma and goma_home_dir is present.
- Priority 3: args.goma and (none of the other two are present + depot_tools dir is present.)
Yes, the borg goma will be turned off by the end of the month and everyone in flutter will need to use fuchsia's gome rbe. |
Setting up fuchsia rbe requires to download different binaries depot tools binaries won't work after the end of this month. |
|
I filed flutter/flutter#70663. @godofredoc Could you add some details there about what we should do, like how to get the right binaries? |
|
@godofredoc , @zanderso given that this will simplify local workflows until goma on borg gets banned, mind if we land this? |
iskakaushik
added
the
waiting for tree to go green
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
lgtm for the temporary landing until we've moved to the fuchsia pool.
6 participants
Useful when following Chromium's External Access Goma Guide.