Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CanvasKit fix embedded view clipping #22937

Merged
merged 5 commits into from
Dec 14, 2020
Merged

CanvasKit fix embedded view clipping #22937

merged 5 commits into from
Dec 14, 2020

Conversation

harryterkelsen
Copy link
Contributor

Description

Fixes embedded view clipping by using html.DocumentFragment.svg to avoid the problem where the clipPath elements were automatically lower-cased.

Related Issues

Fixes flutter/flutter#70618

Tests

I added the following tests:

  • Added a test to embedded_views_test that clipPath is correctly added to the DOM.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change.

@google-cla google-cla bot added the cla: yes label Dec 8, 2020
yjbanov
yjbanov approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chinmaygarde chinmaygarde added the platform-web Code specifically for the web engine label Dec 10, 2020
@harryterkelsen harryterkelsen added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Dec 14, 2020
@fluttergithubbot fluttergithubbot merged commit 360a16a into flutter:master Dec 14, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 14, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 14, 2020
@engine-flutter-autoroll
360a16a CanvasKit fix embedded view clipping (flutter/engine#22937)
6c2b3e8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020
@engine-flutter-autoroll
360a16a CanvasKit fix embedded view clipping (flutter/engine#22937)
dc6ddeb
gspencergoog pushed a commit to gspencergoog/engine that referenced this pull request Jan 5, 2021
@gspencergoog
CanvasKit fix embedded view clipping (flutter#22937)
7d51b00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google_maps wrapped in ClipRRect throws exception in CanvasKit
4 participants
@harryterkelsen @yjbanov @chinmaygarde @fluttergithubbot