Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@abrush21
Copy link
Contributor

@abrush21 abrush21 commented Jan 7, 2021

Description

This change adds a mechanism enabling announce events to be forwarded to/handled by accessibility infra.

Related Issues

https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=67180&q=component%3AAccessibility&can=2

Tests

I added the following tests:

Accessibility bridge UTs for propagation of announce event to a11y.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@chaselatta chaselatta added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 25, 2021
@fluttergithubbot fluttergithubbot merged commit 523c8c8 into flutter:master Jan 25, 2021
zanderso pushed a commit to flutter/flutter that referenced this pull request Jan 26, 2021
* 08daa2c Rename TextInputManager to TextInputManagerWin32 (flutter/engine#23905)

* 611a8d5 Roll Skia from 069e484cc3b9 to 607a382298b2 (1 revision) (flutter/engine#23907)

* aa56ae2 Roll Skia from 607a382298b2 to fe8a4faa4bb2 (4 revisions) (flutter/engine#23910)

* 86e05f0 Roll Fuchsia Linux SDK from mrFdelzNr... to GLRm7LJRm... (flutter/engine#23913)

* 155827a Roll Skia from fe8a4faa4bb2 to bd91660b6e12 (4 revisions) (flutter/engine#23920)

* ef4f5a8 Roll Dart SDK from 2ddf810f71f6 to 70c7daa78288 (1 revision) (flutter/engine#23922)

* 790af8a [macos] Support smooth resizing for Metal (flutter/engine#23924)

* 2707c21 use a single clang toolchain (flutter/engine#23842)

* 523c8c8 Adds a mechanism for announce events to be forwarded to a11y. (flutter/engine#23499)

* ee07d1b Roll Skia from bd91660b6e12 to fff4099358bd (9 revisions) (flutter/engine#23929)
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants