This repository was archived by the owner on Feb 25, 2025. It is now read-only.
WIP: Add TextInput.setEditableSizeAndTransform handler #23792
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inputting text via multi-step text input, such as via Chinese, Japanese, or Korean IME input methods, the framework computes the rectangle of the compose text and updates the embedder via the TextInput.setMarkedTextRect message over the channel. We add a handler for this method which stores the composing rect as a field on TextInputPlugin. In a followup patch, a similar handler will be added for the TextInput.setEditableSizeAndTransform message. Them when compose rect is needed in window coordinates, the rect can be multipled by the 4x4 transform matrix, so the result may be fetched by the view/window class and the IME candidates window position updated.
When inputting text, the framework computes a transform from local coordinates to the coordinate system of PipelineOwner.rootNode and updates the embedder via the TextInput.setEditableSizeAndTransform message over the channel. We add a handler for this method which stores this transform in an array on TextInputPlugin. In a previous patch, a similar handler was be added for the TextInput.setMarkedTextRect message. When compose rect is needed in window coordinates, the rect can be multipled by this 4x4 transform matrix, so the result may be read by the view/window class and the IME candidates window position updated.
cbracken
added
affects: text input
Work in progress (WIP)
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Member
Author
|
Included in #23795. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inputting text, the framework computes a transform from local
coordinates to the coordinate system of PipelineOwner.rootNode and
updates the embedder via the TextInput.setEditableSizeAndTransform
message over the channel.
We add a handler for this method which stores this transform in an array
on TextInputPlugin.
In a previous patch, a similar handler was be added for the
TextInput.setMarkedTextRect message. When compose rect is needed in
window coordinates, the rect can be multipled by this 4x4 transform
matrix, so the result may be read by the view/window class and the
IME candidates window position updated.
Note: This PR is currently stacked on top of #23789.
Issues
This is one in a series of patches addressing flutter/flutter#65574: Full IME support for Windows.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.