Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Android text input] fix android autofill on focused text field #24463

Merged
merged 2 commits into from
Feb 18, 2021
Merged

[Android text input] fix android autofill on focused text field #24463

merged 2 commits into from
Feb 18, 2021

Conversation

LongCatIsLooong
Copy link
Contributor

Fixes flutter/flutter#75833

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Feb 17, 2021
justinmc
justinmc approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java
@@ -418,6 +418,8 @@ private void setPlatformViewTextInputClient(int platformViewId) {
mRestartInputPending = false;
}

// Called by the text input channel to update the text input plugin with the
// latest TextEditState from the framework.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: TextEditState => TextEditingState

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class that this method takes as a parameter is called TextEditState.

shell/platform/android/test/io/flutter/plugin/editing/TextInputPluginTest.java

// The autofill value of the focused field is sent via updateEditingState.
verify(textInputChannel, times(1))
.updateEditingState(anyInt(), eq("focused field"), eq(13), eq(13), eq(-1), eq(-1));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do the 13s come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"focused field".length == 13, the autofill implementation puts the caret at the end.

@LongCatIsLooong LongCatIsLooong added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 18, 2021
@fluttergithubbot fluttergithubbot merged commit e31cb0d into flutter:master Feb 18, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
5fe99d3 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
54144a5 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
6e70d7b 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
f011a7d 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
46a48b7 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
94a700a 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
a6d4c22 
…ld (flutter/engine#24463)
@LongCatIsLooong LongCatIsLooong deleted the fix-android-autofill branch February 18, 2021 17:49
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
202e649 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
773bf17 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
3fc982d 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
5ef1fa6 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
54afc7a 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
93f45e3 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
b622098 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
9146858 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
e71e7d2 
…ld (flutter/engine#24463)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
e31cb0d [Android text input] fix android autofill on focused text fie…
9779f6a 
…ld (flutter/engine#24463)
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@LongCatIsLooong @hjfreyer
[Android text input] fix android autofill on focused text field (flut…
7e41998 
…ter#24463)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinmc justinmc justinmc approved these changes

@GaryQian GaryQian Awaiting requested review from GaryQian

Assignees
No one assigned
Labels
cla: yes platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AutoFill is not working on Android
3 participants
@LongCatIsLooong @justinmc @fluttergithubbot