fuchsia: Handle multiple views in platformViews path #25343
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
arbreng
force-pushed
the
fuchsia-views-threading
branch
from
c162604 to
6dd1830
Compare
|
I'm on PTO through monday, I can look at this on Tuesday if you want but probably not before that |
jaeheon
left a comment
jaeheon
left a comment
There was a problem hiding this comment.
First time reviewing code here... :)
shell/platform/fuchsia/flutter/fuchsia_external_view_embedder.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/flutter/fuchsia_external_view_embedder.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/flutter/fuchsia_external_view_embedder.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/flutter/fuchsia_external_view_embedder.h
Outdated
Show resolved
Hide resolved
arbreng
force-pushed
the
fuchsia-views-threading
branch
from
6dd1830 to
307820f
Compare
jaeheon
left a comment
jaeheon
left a comment
There was a problem hiding this comment.
(need to break for lunch, will continue after)
shell/platform/fuchsia/flutter/fuchsia_external_view_embedder.cc
Outdated
Show resolved
Hide resolved
freiling
left a comment
freiling
left a comment
There was a problem hiding this comment.
LGTM once testing is finished and comments addressed
arbreng
force-pushed
the
fuchsia-views-threading
branch
from
307820f to
514d9a3
Compare
|
@arbreng The test failure looks related. |
Yes, I have some cleanup yet to do on this CL before landing it. It will be this evening or tomorrow That includes breaking up this monster CL into a few distinct commits at least |
arbreng
force-pushed
the
fuchsia-views-threading
branch
3 times, most recently
from
f9d732a to
4ee84df
Compare
arbreng
force-pushed
the
fuchsia-views-threading
branch
from
4ee84df to
00c3f17
Compare
5 participants
The new platformViews path we are introducing for Fuchsia is not able to handle multiple platform views at once. This PR fixes that and enables proper view IDs with platform_view channel events.
Fixes: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=71337