This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Catch image load failures in --release builds #25602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
| const MethodCodec codec = JSONMethodCodec(); | ||
| final String message = 'Error while trying to load an asset $url'; | ||
| if (!assertionsEnabled) { | ||
| /// For web/release mode log the load failure on console. |
Contributor
There was a problem hiding this comment.
Why is this necessary? Shouldn't the _replyToPlatformMessage(...) call below be enough to log the failure?
Contributor
Author
There was a problem hiding this comment.
Why is this necessary? Shouldn't the
_replyToPlatformMessage(...)call below be enough to log the failure?
Otherwise for release builds user gets no indication of failure at all. The error reported by replyToPlatformMessage is silent in release mode.
ferhatb
added a commit
that referenced
this pull request
May 11, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
May 21, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
May 21, 2021
…25602)" (flutter#26073) This reverts commit 304ee81.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When server returns html doc for asset request, instead of failing asset load, the engine was detecting failure much later during decoding.
This PR:
flutter/flutter#74935
Pre-launch Checklist
writing and running engine tests.
///).