This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add dart devtools to DEPS #25912
Closed
Add dart devtools to DEPS #25912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the dart devtools to the DEPS in a way that the autoroller in https://github.com/flutter/buildroot/blob/master/tools/dart/create_updated_flutter_deps.py can pick it up. Breakage Dart SDK: https://dart-review.googlesource.com/c/sdk/+/188361 Corresponding Dart SDK fix: https://dart-review.googlesource.com/c/sdk/+/198042
mkustermann
approved these changes
May 4, 2021
jason-simmons
added a commit
to jason-simmons/flutter_engine
that referenced
this pull request
May 4, 2021
This component will be added to the engine dependencies by flutter#25912
chinmaygarde
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
Member
|
The licenses check will be fixed after #25918 lands. |
jason-simmons
added a commit
to jason-simmons/flutter_engine
that referenced
this pull request
May 7, 2021
This component will be added to the engine dependencies by flutter#25912
Member
|
cc @zanderso for followup. Needs to be rebased. The windows presubmit failures have been fixed. |
zanderso
approved these changes
May 13, 2021
dcharkes
commented
May 17, 2021
| # WARNING: Unused Dart dependencies in the list below till "WARNING:" marker are removed automatically - see create_updated_flutter_deps.py. | ||
|
|
||
| 'src/third_party/dart/third_party/devtools': | ||
| {'packages': [{'version': 'git_revision:' + Var('dart_devtools_rev'), 'package': 'dart/third_party/flutter/devtools'}], 'dep_type': 'cipd'}, |
Contributor
Author
There was a problem hiding this comment.
Var('dart_devtools_rev') on running the update script in buildtools this will be replaced by a hash automatically the next roll.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the dart devtools to the DEPS in a way that the autoroller in
https://github.com/flutter/buildroot/blob/master/tools/dart/create_updated_flutter_deps.py
can pick it up.
Breakage Dart SDK: https://dart-review.googlesource.com/c/sdk/+/188361
Corresponding Dart SDK fix: https://dart-review.googlesource.com/c/sdk/+/198042