Add an allowlist flag for Skia trace event categories #25985
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
|
||
| void InitSkiaEventTracer(bool enabled); | ||
| void InitSkiaEventTracer(bool enabled, | ||
| const std::vector<std::string>& allowlist); |
There was a problem hiding this comment.
Nit: underscore_case for arguments.
There was a problem hiding this comment.
Nevermind. I thought it was allowList. I feel silly.
common/settings.h
Outdated
| bool start_paused = false; | ||
| bool trace_skia = false; | ||
| std::string trace_allowlist; | ||
| std::string trace_skia_allowlist; |
There was a problem hiding this comment.
Can this be a set of string already please? Also for the allowlist maybe. It's impossible to tell from looking at the settings what format of the string needs to be. Looking at the Tokenize method below, it seems like a comma separate list that allows newline? Is that right? Also, can be move Tokenize out of shell.cc as it seems out of place and undocumented there. Perhaps Settings::TokenizeAllowlist that returns the set and also documents the format.
There was a problem hiding this comment.
Moved this into switches.cc
jason-simmons
added
the
waiting for tree to go green
* 304ec46 Roll Skia from 537b7508343d to 6b719c25cade (3 revisions) (flutter/engine#26119) * 75f705b Roll Fuchsia Mac SDK from q1qWG9XiN... to mdsssGtoC... (flutter/engine#26123) * 0fc1bea Add an allowlist flag for Skia trace event categories (flutter/engine#25985) * 917371f Use PackageManager to locate installed UWP apps (flutter/engine#26120)
3 participants
See flutter/flutter#78500