Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for Dart entrypoint arguments on Windows #27497

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Add unit tests for Dart entrypoint arguments on Windows #27497

merged 2 commits into from
Jul 19, 2021

Conversation

gw280
Copy link
Contributor

@gw280 gw280 commented Jul 16, 2021

Backfill unit tests for #22094

flutter/flutter#32986

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@gw280 gw280 requested review from chinmaygarde and clarkezone July 16, 2021 23:11
@google-cla google-cla bot added the cla: yes label Jul 16, 2021
clarkezone
clarkezone approved these changes Jul 17, 2021
View reviewed changes
Copy link
Contributor

@clarkezone clarkezone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gw280 gw280 merged commit f873cd0 into flutter:master Jul 19, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 20, 2021
@engine-flutter-autoroll
f873cd0 Add unit tests for Dart entrypoint arguments on Windows (flut…
d472465 
…ter/engine#27497)
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
Add unit tests for Dart entrypoint arguments on Windows (flutter#27497)
0825b13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkezone clarkezone clarkezone approved these changes

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees
No one assigned
Labels
cla: yes platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gw280 @chinmaygarde @clarkezone