Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll gyp to 4801a5331ae62da9769a327f11c4213d32fb0dad #27820

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Roll gyp to 4801a5331ae62da9769a327f11c4213d32fb0dad #27820

merged 1 commit into from
Jul 30, 2021

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Jul 30, 2021 •
edited
Loading

This picks up several Python 3 compatibility fixes from upstream.

Issue: flutter/flutter#83043

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jul 30, 2021
@cbracken
Roll gyp to 4801a53
65e8b66 
This picks up several Python 3 compatibility fixes from upstream.
@cbracken cbracken merged commit 29f9df7 into flutter:master Jul 30, 2021
@cbracken cbracken deleted the roll-gyp branch July 30, 2021 22:08
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2021
@engine-flutter-autoroll
29f9df7 Roll gyp to 4801a5331ae62da9769a327f11c4213d32fb0dad (flutter…
15b873a 
…/engine#27820)
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@cbracken
Roll gyp to 4801a53 (flutter#27820)
d1c9ceb 
This picks up several Python 3 compatibility fixes from upstream.
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
@cbracken @filmil
Roll gyp to 4801a53 (flutter#27820)
6a9ed78 
This picks up several Python 3 compatibility fixes from upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbracken @jason-simmons