Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Python 3 for all gn exec_script calls #27835

Merged
merged 1 commit into from
Jul 31, 2021
Merged

Enable Python 3 for all gn exec_script calls #27835

merged 1 commit into from
Jul 31, 2021

Conversation

cbracken
Copy link
Member

This rolls buildroot to 630be43.

Fixes: flutter/flutter#83043

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jul 31, 2021
@cbracken cbracken merged commit c555dc0 into flutter:master Jul 31, 2021
@cbracken cbracken deleted the flip-python3 branch July 31, 2021 01:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2021
@engine-flutter-autoroll
c555dc0 Enable Python 3 for all gn exec_script calls (flutter/engine#…
612e6b9 
…27835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2021
@engine-flutter-autoroll
c555dc0 Enable Python 3 for all gn exec_script calls (flutter/engine#…
8e27e31 
…27835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2021
@engine-flutter-autoroll
c555dc0 Enable Python 3 for all gn exec_script calls (flutter/engine#…
e2eb797 
…27835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2021
@engine-flutter-autoroll
c555dc0 Enable Python 3 for all gn exec_script calls (flutter/engine#…
69e9b4a 
…27835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2021
@engine-flutter-autoroll
c555dc0 Enable Python 3 for all gn exec_script calls (flutter/engine#…
7841434 
…27835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2021
@engine-flutter-autoroll
c555dc0 Enable Python 3 for all gn exec_script calls (flutter/engine#…
7c08668 
…27835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2021
@engine-flutter-autoroll
c555dc0 Enable Python 3 for all gn exec_script calls (flutter/engine#…
7615b6e 
…27835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2021
@engine-flutter-autoroll
c555dc0 Enable Python 3 for all gn exec_script calls (flutter/engine#…
f2a6333 
…27835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2021
@engine-flutter-autoroll
c555dc0 Enable Python 3 for all gn exec_script calls (flutter/engine#…
1ba86ae 
…27835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2021
@engine-flutter-autoroll
c555dc0 Enable Python 3 for all gn exec_script calls (flutter/engine#…
f86807d 
…27835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2021
@engine-flutter-autoroll
c555dc0 Enable Python 3 for all gn exec_script calls (flutter/engine#…
6801640 
…27835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2021
@engine-flutter-autoroll
c555dc0 Enable Python 3 for all gn exec_script calls (flutter/engine#…
f081193 
…27835)
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@cbracken
Enable Python 3 for all gn exec_script calls (flutter#27835)
7ac6d7a 
This rolls buildroot to 630be43.

Fixes: flutter/flutter#83043
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
@cbracken @filmil
Enable Python 3 for all gn exec_script calls (flutter#27835)
a4038e0 
This rolls buildroot to 630be43.

Fixes: flutter/flutter#83043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate engine tools/gn script (and others) to work with Python 3
2 participants
@cbracken @jason-simmons