Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundletool to DEPS and remove outdated header comment #28040

Merged
merged 5 commits into from
Aug 17, 2021

Conversation

GaryQian
Copy link
Contributor

Bundletool is needed to run integration tests for deferred components such as flutter/flutter#88030

Also removes the outdated header at the top of DEPS.

@GaryQian GaryQian requested a review from chinmaygarde August 12, 2021 09:53
@google-cla google-cla bot added the cla: yes label Aug 12, 2021
@GaryQian GaryQian merged commit 589b6a2 into flutter:master Aug 17, 2021
@rmistry
Copy link
Contributor

rmistry commented Aug 17, 2021

Rollers into flutter engine (skia, dart, flutter sdk) are failing while running the license scripts after this change.

Logs:

I0817 13:06:18.259680      14 state_machine.go:838] Attempting to perform transition from "idle" to "active": upload roll
I0817 13:06:19.471315      14 deps_local.go:66] Running: python /data/depot_tools/gclient.py sync --delete_unversioned_trees --force
I0817 13:06:33.001540      14 deps_local.go:138] Running 1 pre-upload steps.
I0817 13:06:33.001575      14 pre_upload_steps.go:188] Running flutter license scripts.
I0817 13:06:33.001588      14 pre_upload_steps.go:194] Running put get.
I0817 13:06:33.452960      14 pre_upload_steps.go:209] Running [/data/src/third_party/dart/tools/sdks/dart-sdk/bin/dart lib/main.dart --src ../../.. --out /data/src/out/licenses --golden /data/src/flutter/ci/licenses_golden]
I0817 13:06:33.453023      14 exec.go:212] Executing '/data/src/third_party/dart/tools/sdks/dart-sdk/bin/dart lib/main.dart --src ../../.. --out /data/src/out/licenses --golden /data/src/flutter/ci/licenses_golden' (where /data/src/third_party/dart/tools/sdks/dart-sdk/bin/dart is /data/src/third_party/dart/tools/sdks/dart-sdk/bin/dart) with CWD /data/src/flutter/tools/licenses
lib/main.dart: Warning: Interpreting this as package URI, 'package:licenses/main.dart'.
Finding files...
../../../third_party/bundletool/.DS_Store
failed to handle ../../../third_party/bundletool/.DS_Store: FormatException: Unexpected extension byte (at offset 23)
failure: FormatException: Unexpected extension byte (at offset 23)
#0      _Utf8Decoder.convertSingle (dart:convert-patch/convert_patch.dart:1788:7)
#1      Utf8Decoder.convert (dart:convert/utf.dart:318:42)
#2      Utf8Codec.decode (dart:convert/utf.dart:63:20)
#3      UTF8TextFile.readString.<anonymous closure> (package:licenses/filesystem.dart:326:45)
#4      cache (package:licenses/cache.dart:15:20)
#5      UTF8TextFile.readString (package:licenses/filesystem.dart:326:14)
#6      _RepositoryApache4DNoticeFile.consider (package:licenses/main.dart:202:15)
#7      _RepositoryDirectory.createFile (package:licenses/main.dart:947:41)
#8      _RepositoryDirectory.crawl (package:licenses/main.dart:882:43)
#9      new _RepositoryDirectory (package:licenses/main.dart:856:5)
#10     new _RepositoryBundletoolDirectory (package:licenses/main.dart:1501:82)
#11     _RepositoryRootThirdPartyDirectory.createSubdirectory (package:licenses/main.dart:1872:14)
#12     _RepositoryDirectory.crawl (package:licenses/main.dart:877:46)
#13     new _RepositoryDirectory (package:licenses/main.dart:856:5)
#14     new _RepositoryGenericThirdPartyDirectory (package:licenses/main.dart:1242:89)
#15     new _RepositoryRootThirdPartyDirectory (package:licenses/main.dart:1811:86)
#16     _EngineSrcDirectory.createSubdirectory (package:licenses/main.dart:2376:14)
#17     _RepositoryDirectory.crawl (package:licenses/main.dart:877:46)
#18     new _RepositoryDirectory (package:licenses/main.dart:856:5)
#19     new _EngineSrcDirectory (package:licenses/main.dart:2346:42)
#20     main (package:licenses/main.dart:2625:39)
#21     _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:281:32)
#22     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

aborted.

FYI @dnfield @zanderso

zanderso added a commit that referenced this pull request Aug 17, 2021
zanderso added a commit that referenced this pull request Aug 17, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2021
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants