-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dead key handling on Win32 (again) #28125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkwingsmt, thank you for this! There is one issue that I noticed. Normal behavior in windows, when pressing the dead key twice is that it gets printed twice. I.e. ´´, with no dead key state afterwards. However pressing the dead key twice in Flutter prints the first dead key while the second dead key becomes active. |
@knopp That's interesting to know! I'll take a look afterwards. Thank you. |
- Fix dead character crashes the channel handler. - Fix dead key messages are redispatched, making the message a regular character message.
This PR tries to fix dead key handling on Win32:
It fixes the problem raised in #28047 (comment).
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.