Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci.yaml] Promote roller to blocking #28134

Merged
merged 1 commit into from
Aug 17, 2021
Merged

[ci.yaml] Promote roller to blocking #28134

merged 1 commit into from
Aug 17, 2021

Conversation

CaseyHillers
Copy link
Contributor

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Aug 17, 2021
christopherfujino
christopherfujino approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 17, 2021
@fluttergithubbot fluttergithubbot merged commit 8326455 into master Aug 17, 2021
@zanderso
Copy link
Member

I am not comfortable with this. The recipe that does this pulls many repos from head, and so could therefore cause the Engine tree to turn red due to commits to other repos.

@zanderso
Copy link
Member

/cc @godofredoc

CaseyHillers added a commit that referenced this pull request Aug 17, 2021
@CaseyHillers
Revert "[ci.yaml] Move roller to blocking (#28134)"
ca5f53d 
This reverts commit 8326455.
@CaseyHillers CaseyHillers mentioned this pull request Aug 17, 2021
Merged
fluttergithubbot pushed a commit that referenced this pull request Aug 17, 2021
Revert "[ci.yaml] Move roller to blocking (#28134)" (#28143)
2b0ef0a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 17, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2021
@engine-flutter-autoroll
8326455 [ci.yaml] Move roller to blocking (flutter/engine#28134)
4b9f050
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2021
@engine-flutter-autoroll
8326455 [ci.yaml] Move roller to blocking (flutter/engine#28134)
05758c0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2021
@engine-flutter-autoroll
8326455 [ci.yaml] Move roller to blocking (flutter/engine#28134)
5dea360
@CaseyHillers CaseyHillers deleted the CaseyHillers-patch-5 branch November 18, 2021 22:08
@CaseyHillers CaseyHillers mentioned this pull request Apr 5, 2022
Closed
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
@filmil
[ci.yaml] Move roller to blocking (flutter#28134)
ce86029
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
@filmil
Revert "[ci.yaml] Move roller to blocking (flutter#28134)" (flutter#2…
a2dce8f 
…8143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CaseyHillers @zanderso @christopherfujino @fluttergithubbot