This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fuchsia: Add FuchsiaExternalViewEmbedder tests #28144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbreng
added
affects: tests
platform-fuchsia
tech-debt
chandarrengoog
approved these changes
Aug 20, 2021
jaeheon
approved these changes
Aug 20, 2021
shell/platform/fuchsia/flutter/tests/fakes/scenic/fake_resources.h
Outdated
Show resolved
Hide resolved
Member
|
@arbreng Can we fix the conflict and land this please? |
arbreng
force-pushed
the
fuchsia-external-view-embedder-tests
branch
2 times, most recently
from
5e9a65b to
a68b214
Compare
arbreng
force-pushed
the
fuchsia-external-view-embedder-tests
branch
from
a68b214 to
eb9bd7b
Compare
arbreng
force-pushed
the
fuchsia-external-view-embedder-tests
branch
from
d7fe04e to
d77194b
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 17, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 17, 2021
akbiggs
pushed a commit
to akbiggs/engine
that referenced
this pull request
Sep 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the FakeSession, finally add unit tests for flutter's rendering interactions with scenic.
Test: Added fuchsia_external_view_embedder_unitests
Fixes: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=79873