Use Android linter from cmdline-tools #28153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryQian
reviewed
Aug 18, 2021
| @@ -106,14 +104,13 @@ Future<int> runLint(ArgParser argParser, ArgResults argResults) async { | |||
| if (html) { | |||
| lintArgs.addAll(<String>['--html', argResults['out'] as String]); | |||
| } | |||
| final String? javaHome = await getJavaHome(); | |||
| final String javahome = getJavaHome(inArgument); | |||
| print('Using JAVA_HOME=$javahome'); | |||
There was a problem hiding this comment.
nit: Is this print meant to be here?
There was a problem hiding this comment.
it's intended. It helps inform the user of this script that this ENV variable is set. Particularly, relevant in CI.
GaryQian
reviewed
Aug 18, 2021
shell/platform/android/io/flutter/embedding/android/FlutterImageView.java
Show resolved
Hide resolved
GaryQian
reviewed
Aug 18, 2021
| @@ -43,7 +43,7 @@ | |||
| * The most obvious example of when this may come in handy is if an application wishes to subclass | |||
| * the Android v4 support library's {@code FragmentActivity}. | |||
| * | |||
| * <p><b>Usage:</b></p> | |||
There was a problem hiding this comment.
Any reason why the closing
was removed?There was a problem hiding this comment.
The closing tag </p> isn't required. See this thread google/google-java-format#61
blasten
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 18, 2021
blasten
pushed a commit
to blasten/flutter
that referenced
this pull request
Aug 19, 2021
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Android linter from cmdline-tools.
We are currently using the one from
tools/bin/lintwhich is very old, and doesn't work with Java 11.