Fix eglPresentationTimeANDROID is no effective #30182

MxSoul · 2021-12-07T08:32:31Z

After Fix

Kindly See Log

eglPresentationTimeANDROID-fixed.log
[download it and delete .log . And use https://ui.perfetto.dev/ to open it]

Can see trace also. Between the Red Flag to Blue Flag is one frame. In this frame raster commit 2 buffer to bufferQueue. These 2 buffer is used/discard in the next Vsync-sf (Blue Flag).

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2021-12-07T08:32:51Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

dnfield · 2021-12-07T14:57:01Z

This may need a rebase to get the windows tests passing. Thanks for catching this! I guess I forgot to rerun a local benchmark before refactoring this and then hadn't checked the benchmarks again after landing it.

MxSoul · 2021-12-08T10:55:00Z

@dnfield Thanks for review. I have rebase main and all test passed ~

dnfield

Lgtm

blasten · 2021-12-08T19:15:57Z

shell/platform/android/android_environment_gl.cc

  if (strstr(extensions, "EGL_ANDROID_presentation_time")) {
    presentation_time_proc_ =
        reinterpret_cast<PFNEGLPRESENTATIONTIMEANDROIDPROC>(
-            eglGetProcAddress("sEGL_ANDROID_presentation_time"));


should this have been EGL_ANDROID_presentation_time ? What is the relationship between this value and L24? @dnfield

I think what happened here is that I meant to copy and paste eglPresentationTimeANDROID, and instead I copy and pasted EGL_ANDROID_presentation_time .. and hit the s key by accident .. and then didn't notice it.

When I initially did some tests with this extension, I was just directly calling it and hacking it in as if it wouldn't have to be looked up. I then refactored to do it the right way (get the proc address this way), but never re-tested things to make sure it was still doing the good thing.. and then this got missed in review :(

@iskakaushik FYI since I think you reviewed the original PR

The bottom line is: this lookup is correct and we should accept it.

Maybe can see this L92 and L193
https://cs.android.com/android/platform/superproject/+/android-10.0.0_r1:frameworks/native/opengl/libs/EGL/egl_platform_entries.cpp;l=92

In my opinion:
EGL_ANDROID_presentation_time is gBuiltinExtensionString, and It is used to determine whether an extension point exists.
eglPresentationTimeANDROID is key when get address.

could we add a comment about what EGL_ANDROID_presentation_time and eglPresentationTimeANDROID are used for?

It will definitely help next time there's a refactor, and the blame doesn't point to this PR. :)

Sorry, I am not native speaker. I'm not sure my description is accurate. Maybe @dnfield could help to add this comment?

@blasten I added some comments.

…e#30182)

* 37223ca [fuchsia] Use network-legacy-deprecated pkg in embedder test (flutter/engine#30244) * 86769ee Roll Dart SDK from 2ace65b1b408 to 2091ff49c513 (8 revisions) (flutter/engine#30251) * 5312e55 Win32: Handle OnAccessibilityEvent (flutter/engine#30176) * 8fd8912 Revert the latest rolls of the Fuchsia SDK (flutter/engine#30254) * df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine#30256) * 6aa8d5c Simplify win32 platform node delegate GetParent (flutter/engine#30258) * ff328f0 Fix TestAccessibilityBridgeDelegate event caching (flutter/engine#30260) * 842281e Test shell/platform/common a11y code on Windows (flutter/engine#30262) * 806d8bc Roll Dart SDK from 2091ff49c513 to 7b6056f9db7f (1 revision) (flutter/engine#30259) * 1ed10bb Android accessibility bridge also fire selection change event when it predict selection change. (flutter/engine#30199) * 71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/engine#30261) * 5aa7b30 Cleanup old ndk CIPD upload script (flutter/engine#30253) * 3653881 Roll Fuchsia Mac SDK from EcjcLVqar... to 1DgBWWOWV... (flutter/engine#30265) * f764864 Roll Skia from 44c81d149273 to a964a72174e8 (9 revisions) (flutter/engine#30255) * 2eca05e Migrate to Mockito 4.1.0 (flutter/engine#30257) * 1a6005f Add iOS version to scenario golden images (flutter/engine#30263) * 59c6f28 Roll Fuchsia Linux SDK from 3rLypXNTd... to UPWdoQziF... (flutter/engine#30266) * 5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engine#30182) * bb20dd0 Roll Skia from a964a72174e8 to 4d35c0d31d79 (16 revisions) (flutter/engine#30269) * 33f4c32 Revert "Accessibility number formatting improvements for Windows (#29773)" (flutter/engine#30267) * 5ece42f Roll Dart SDK from 7b6056f9db7f to f568598a262e (4 revisions) (flutter/engine#30270) * 8d1272b Roll Dart SDK from f568598a262e to 49d5a2f58c4a (3 revisions) (flutter/engine#30277) * 8b074c8 Roll Fuchsia Mac SDK from 1DgBWWOWV... to GoQ7KEnqp... (flutter/engine#30278) * e1a71cf Roll Fuchsia Linux SDK from UPWdoQziF... to hhFGKobVD... (flutter/engine#30279) * 6dc4046 Roll Fuchsia Mac SDK from GoQ7KEnqp... to Y_9lCzY64... (flutter/engine#30280) * ff7d4d6 Roll Fuchsia Linux SDK from hhFGKobVD... to NAkkk-Vn5... (flutter/engine#30281) * 2f97ac4 Roll Dart SDK from 49d5a2f58c4a to 01a9d4e9ede7 (1 revision) (flutter/engine#30283) * 85f4d68 Roll Fuchsia Linux SDK from NAkkk-Vn5... to V2JLZw4H1... (flutter/engine#30285) * 5130b83 Roll Fuchsia Mac SDK from Y_9lCzY64... to xBCcWw6gj... (flutter/engine#30284) * e28882a Roll Dart SDK from 01a9d4e9ede7 to a78eae43582d (1 revision) (flutter/engine#30288) * 368e3cc Revert Dart SDK to 2ace65b1b408 (flutter/engine#30290)

This reverts commit 5502a0a.

* Revert "Fix eglPresentationTimeANDROID is no effective (#30182)" This reverts commit 5502a0a. * Revert "Use eglPresentationTimeANDROID to avoid bogging down the GPU (#29727)" This reverts commit 88948de.

flutter-dashboard bot added the platform-android label Dec 7, 2021

flutter-dashboard bot added the needs tests label Dec 7, 2021

MxSoul mentioned this pull request Dec 7, 2021

eglPresentationTimeANDROID is no effective flutter/flutter#94786

Closed

ColdPaleLight requested a review from dnfield December 7, 2021 11:11

MxSoul force-pushed the fix_presentation_time branch from 30e04fe to f3b5eb6 Compare December 7, 2021 11:25

Fix eglPresentationTimeANDROID is no effective

de18d90

MxSoul force-pushed the fix_presentation_time branch from f3b5eb6 to de18d90 Compare December 7, 2021 11:27

Merge branch 'flutter:main' into fix_presentation_time

6b72448

dnfield approved these changes Dec 8, 2021

View reviewed changes

blasten reviewed Dec 8, 2021

View reviewed changes

Update android_environment_gl.cc

a99c6b4

blasten approved these changes Dec 10, 2021

View reviewed changes

dnfield merged commit 5502a0a into flutter:main Dec 10, 2021

engine-flutter-autoroll mentioned this pull request Dec 10, 2021

Roll Engine from 79f750d4a541 to 5502a0ad57b7 (18 revisions) flutter/flutter#95042

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

ed0c615

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 10, 2021

Roll Engine from 79f750d4a541 to 5ece42fee466 (21 revisions) flutter/flutter#95052

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

b61bf26

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to 5ece42fee466 (21 revisions) flutter/flutter#95062

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

e09e007

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to 5ece42fee466 (21 revisions) flutter/flutter#95067

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

3605d23

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to 8d1272ba34d5 (22 revisions) flutter/flutter#95072

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

ccf1874

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to 8b074c8159a6 (23 revisions) flutter/flutter#95077

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

294d80d

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to e1a71cf0daf8 (24 revisions) flutter/flutter#95078

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

79974c2

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to e1a71cf0daf8 (24 revisions) flutter/flutter#95081

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

8bf1a6d

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to e1a71cf0daf8 (24 revisions) flutter/flutter#95086

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

36c9ca2

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to ff7d4d6a0920 (26 revisions) flutter/flutter#95096

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

c6a6169

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to ff7d4d6a0920 (26 revisions) flutter/flutter#95099

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

01a089e

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 2f97ac4217b1 (27 revisions) flutter/flutter#95102

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

f7852f7

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 2f97ac4217b1 (27 revisions) flutter/flutter#95106

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

14c33af

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 2f97ac4217b1 (27 revisions) flutter/flutter#95111

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

93a87c8

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 85f4d6861a5c (28 revisions) flutter/flutter#95112

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

0e8c3fe

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 5130b83da049 (29 revisions) flutter/flutter#95114

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

44ac4d7

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 5130b83da049 (29 revisions) flutter/flutter#95119

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

f4f0a2e

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 5130b83da049 (29 revisions) flutter/flutter#95124

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

2edc568

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to e28882a1efdc (30 revisions) flutter/flutter#95128

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

d68da23

…e#30182)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 368e3cc50592 (31 revisions) flutter/flutter#95132

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engin…

4477317

…e#30182)

dnfield added a commit that referenced this pull request Dec 14, 2021

Revert "Fix eglPresentationTimeANDROID is no effective (#30182)"

03ebeea

This reverts commit 5502a0a.

dnfield mentioned this pull request Dec 14, 2021

Revert "Fix eglPresentationTimeANDROID is no effective" #30310

Merged

Fix eglPresentationTimeANDROID is no effective #30182

Fix eglPresentationTimeANDROID is no effective #30182

Uh oh!

Conversation

MxSoul commented Dec 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

After Fix

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Dec 7, 2021

Uh oh!

dnfield commented Dec 7, 2021

Uh oh!

MxSoul commented Dec 8, 2021

Uh oh!

dnfield left a comment

Choose a reason for hiding this comment

Uh oh!

blasten Dec 8, 2021

Choose a reason for hiding this comment

Uh oh!

dnfield Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

dnfield Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

dnfield Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

MxSoul Dec 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blasten Dec 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MxSoul Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

dnfield Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MxSoul commented Dec 7, 2021 •

edited

Loading

MxSoul Dec 9, 2021 •

edited

Loading

blasten Dec 9, 2021 •

edited

Loading