Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the GLFW example compiles. #30442

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Conversation

chinmaygarde
Copy link
Member

The example itself remains unchanged. Just an GN build rule has been added in
addition to the CMake example.

The example itself remains unchanged. Just an GN build rule has been added in
addition to the CMake example.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added embedder Related to the embedder API needs tests labels Dec 21, 2021
@chinmaygarde
Copy link
Member Author

Thanks! I thought you were OOO though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embedder Related to the embedder API needs tests waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants