Remove unused field initializing formal parameters. #30822

scheglov · 2022-01-12T21:06:31Z

We would like to land https://dart-review.googlesource.com/c/sdk/+/226962 to the analyzer, and fixing existing violations.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2022-01-12T21:06:33Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jonahwilliams · 2022-01-12T23:11:58Z

lib/web_ui/lib/src/ui/window.dart

@@ -252,11 +252,11 @@ class IsolateNameServer {
 SingletonFlutterWindow get window => engine.window;

 class FrameData {


I think this is trying to implement the same API as something that is defined in the "regular" dart:ui. Since the engine doesn't use patch files, this would leave unused parameters

engine/lib/ui/window.dart

Line 874 in 93f3991

class FrameData {

So this might need an ignore

oh wait, its a private constructor

jonahwilliams

LGTM but @Hixie for lack of tests. Though this might be exempt because it fixes something that an upcoming lint would flag? I don't quite remember

scheglov · 2022-01-12T23:20:44Z

Such tests definitely exist for the code that reports this hint in new situations, but here we fix places where this hint is reported, so I would be surprised to have any new tests here.

jonahwilliams · 2022-01-12T23:21:45Z

Yeah I agree, I don't think it makes sense for upcoming lints but I don't recall the rules 😄

Hixie · 2022-01-12T23:27:19Z

test-exempt: code refactor with no semantic change

fwiw, rules are described at https://github.com/flutter/flutter/wiki/Tree-hygiene#tests (linked to from the message above), if there's anything unclear let me know. :-)

…engine#30822)

flutter/engine@fab1982...83d99a5 2022-01-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 35I2K_Bou... to V541xkYVr... (flutter/engine#30879) 2022-01-14 skia-flutter-autoroll@skia.org Roll Dart SDK from dcab0d0b2f6c to d0d4dbfc6e69 (1 revision) (flutter/engine#30878) 2022-01-14 skia-flutter-autoroll@skia.org Roll Skia from 1f0e64acd621 to f260a297c68d (1 revision) (flutter/engine#30877) 2022-01-14 638538+chaselatta@users.noreply.github.com [fuchsia] stamp package with target api level (flutter/engine#30857) 2022-01-14 skia-flutter-autoroll@skia.org Roll Skia from dd9e165ef7d0 to 1f0e64acd621 (1 revision) (flutter/engine#30876) 2022-01-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from BQ2l2096A... to bGW3xlB1D... (flutter/engine#30875) 2022-01-14 skia-flutter-autoroll@skia.org Roll Skia from 7aec4b164e79 to dd9e165ef7d0 (1 revision) (flutter/engine#30874) 2022-01-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 68ccd13498be to dcab0d0b2f6c (1 revision) (flutter/engine#30872) 2022-01-14 skia-flutter-autoroll@skia.org Roll Dart SDK from aa6fbac07951 to 68ccd13498be (1 revision) (flutter/engine#30870) 2022-01-14 skia-flutter-autoroll@skia.org Roll Skia from 76e62d32d979 to 7aec4b164e79 (1 revision) (flutter/engine#30869) 2022-01-14 skia-flutter-autoroll@skia.org Roll Skia from a6f2ebf30fea to 76e62d32d979 (1 revision) (flutter/engine#30868) 2022-01-14 skia-flutter-autoroll@skia.org Roll Dart SDK from ba044d5e9c03 to aa6fbac07951 (1 revision) (flutter/engine#30867) 2022-01-14 skia-flutter-autoroll@skia.org Roll Skia from 7c80b2f08ead to a6f2ebf30fea (1 revision) (flutter/engine#30863) 2022-01-14 dkwingsmt@users.noreply.github.com [Windows, Keyboard] Lift key event redispatching to KeyboardManagerWin32 (flutter/engine#30702) 2022-01-14 jason-simmons@users.noreply.github.com Ensure that PlatformViewIOS does not call into Shell semantics APIs during destruction (flutter/engine#30835) 2022-01-14 skia-flutter-autoroll@skia.org Roll Skia from 119fb6bb2568 to 7c80b2f08ead (1 revision) (flutter/engine#30862) 2022-01-14 skia-flutter-autoroll@skia.org Roll Dart SDK from b36d861d5487 to ba044d5e9c03 (1 revision) (flutter/engine#30861) 2022-01-14 skia-flutter-autoroll@skia.org Roll Skia from 62b32180c192 to 119fb6bb2568 (1 revision) (flutter/engine#30860) 2022-01-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Uvw9UoGSm... to BQ2l2096A... (flutter/engine#30859) 2022-01-13 gw280@google.com Move SoftwareCanvasProvider into its own source file (flutter/engine#30856) 2022-01-13 skia-flutter-autoroll@skia.org Roll Skia from c505bdca9d60 to 62b32180c192 (1 revision) (flutter/engine#30855) 2022-01-13 gw280@google.com Create a DisplayList benchmarks dylib on iOS (flutter/engine#30833) 2022-01-13 gw280@google.com Don't retain the MTLTexture or MTLDevice in TestMetalContext (flutter/engine#30832) 2022-01-13 skia-flutter-autoroll@skia.org Roll Skia from 455e580b9c78 to c505bdca9d60 (1 revision) (flutter/engine#30852) 2022-01-13 74682667+chandarrengoog@users.noreply.github.com Roll buildroot to 7effd69. (flutter/engine#30851) 2022-01-13 scheglov@google.com Remove unused field initializing formal parameters. (flutter/engine#30822) 2022-01-13 skia-flutter-autoroll@skia.org Roll Dart SDK from f1c98a571d1a to b36d861d5487 (1 revision) (flutter/engine#30850) 2022-01-13 skia-flutter-autoroll@skia.org Roll Skia from 759bc62a06d2 to 455e580b9c78 (2 revisions) (flutter/engine#30849) 2022-01-13 43054281+camsim99@users.noreply.github.com Remove usages of deprecated setSystemUiVisibility() (flutter/engine#29493) 2022-01-13 skia-flutter-autoroll@skia.org Roll Skia from b21c4af0f670 to 759bc62a06d2 (3 revisions) (flutter/engine#30848) 2022-01-13 akbiggs@users.noreply.github.com [fuchsia] Switch from core-jit to core snapshots. (flutter/engine#30744) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 35I2K_BouXUN to V541xkYVrdUC fuchsia/sdk/core/mac-amd64 from Uvw9UoGSmIjy to bGW3xlB1DoAm

…engine#30822)

* a193f08 [fuchsia] Switch from core-jit to core snapshots. (flutter/engine#30744) * 7e50462 Roll Skia from b21c4af0f670 to 759bc62a06d2 (3 revisions) (flutter/engine#30848) * 8db5038 Remove usages of deprecated setSystemUiVisibility() (flutter/engine#29493) * c05d0df Roll Skia from 759bc62a06d2 to 455e580b9c78 (2 revisions) (flutter/engine#30849) * 1fab2fb Roll Dart SDK from f1c98a571d1a to b36d861d5487 (1 revision) (flutter/engine#30850) * f9385e7 Remove unused field initializing formal parameters. (flutter/engine#30822) * b6e5d99 Roll buildroot to 7effd69. (flutter/engine#30851) * 742eaf8 Roll Skia from 455e580b9c78 to c505bdca9d60 (1 revision) (flutter/engine#30852) * d0f2beb Don't retain the MTLTexture or MTLDevice in TestMetalContext (flutter/engine#30832) * f121c1f Create a DisplayList benchmarks dylib on iOS (flutter/engine#30833) * 4499797 Roll Skia from c505bdca9d60 to 62b32180c192 (1 revision) (flutter/engine#30855) * fcf7458 Move SoftwareCanvasProvider into its own source file (flutter/engine#30856) * 794a833 Roll Fuchsia Mac SDK from Uvw9UoGSm... to BQ2l2096A... (flutter/engine#30859) * 4b32e1c Roll Skia from 62b32180c192 to 119fb6bb2568 (1 revision) (flutter/engine#30860) * facfa74 Roll Dart SDK from b36d861d5487 to ba044d5e9c03 (1 revision) (flutter/engine#30861) * f6613c9 Roll Skia from 119fb6bb2568 to 7c80b2f08ead (1 revision) (flutter/engine#30862) * fb3ee7f Ensure that PlatformViewIOS does not call into Shell semantics APIs during destruction (flutter/engine#30835) * 073e6c5 [Windows, Keyboard] Lift key event redispatching to KeyboardManagerWin32 (flutter/engine#30702) * 88e67a2 Roll Skia from 7c80b2f08ead to a6f2ebf30fea (1 revision) (flutter/engine#30863) * 1f4e7fa Roll Dart SDK from ba044d5e9c03 to aa6fbac07951 (1 revision) (flutter/engine#30867) * 3fbd427 Roll Skia from a6f2ebf30fea to 76e62d32d979 (1 revision) (flutter/engine#30868) * b6db081 Roll Skia from 76e62d32d979 to 7aec4b164e79 (1 revision) (flutter/engine#30869) * b92fd27 Roll Dart SDK from aa6fbac07951 to 68ccd13498be (1 revision) (flutter/engine#30870) * 8961366 Roll Dart SDK from 68ccd13498be to dcab0d0b2f6c (1 revision) (flutter/engine#30872) * 18ea2ce Roll Skia from 7aec4b164e79 to dd9e165ef7d0 (1 revision) (flutter/engine#30874) * 9d660d9 Roll Fuchsia Mac SDK from BQ2l2096A... to bGW3xlB1D... (flutter/engine#30875) * ad68b1b Roll Skia from dd9e165ef7d0 to 1f0e64acd621 (1 revision) (flutter/engine#30876) * b61a6f5 [fuchsia] stamp package with target api level (flutter/engine#30857) * 5787489 Roll Skia from 1f0e64acd621 to f260a297c68d (1 revision) (flutter/engine#30877) * 87ba2d8 Roll Dart SDK from dcab0d0b2f6c to d0d4dbfc6e69 (1 revision) (flutter/engine#30878) * 83d99a5 Roll Fuchsia Linux SDK from 35I2K_Bou... to V541xkYVr... (flutter/engine#30879) * 50adf4c Revert "Remove usages of deprecated setSystemUiVisibility()" (flutter/engine#30880)

Remove unused field initializing formal parameters.

51bd226

flutter-dashboard bot added platform-web Code specifically for the web engine needs tests labels Jan 12, 2022

scheglov requested a review from jonahwilliams January 12, 2022 21:48

jonahwilliams reviewed Jan 12, 2022

View reviewed changes

jonahwilliams approved these changes Jan 12, 2022

View reviewed changes

scheglov merged commit f9385e7 into flutter:main Jan 13, 2022

scheglov deleted the fix-UNUSED_ELEMENT_PARAMETER branch January 13, 2022 21:24

engine-flutter-autoroll mentioned this pull request Jan 13, 2022

Roll Engine from fab19829949d to b6e5d999c229 (7 revisions) flutter/flutter#96628

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2022

f9385e7 Remove unused field initializing formal parameters. (flutter/…

fe2df24

…engine#30822)

engine-flutter-autoroll mentioned this pull request Jan 13, 2022

Roll Engine from fab19829949d to f121c1fe6843 (10 revisions) flutter/flutter#96631

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2022

f9385e7 Remove unused field initializing formal parameters. (flutter/…

356a8f3

…engine#30822)

JsouLiang pushed a commit to JsouLiang/engine that referenced this pull request Jan 14, 2022

Remove unused field initializing formal parameters. (flutter#30822)

d36c953

engine-flutter-autoroll mentioned this pull request Jan 14, 2022

Roll Engine from fab19829949d to 83d99a58097b (31 revisions) flutter/flutter#96673

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 14, 2022

f9385e7 Remove unused field initializing formal parameters. (flutter/…

5bd9670

…engine#30822)

iskakaushik mentioned this pull request Jan 15, 2022

Roll Engine from fab19829949d to 83d99a58097b (31 revisions) flutter/flutter#96687

Closed

engine-flutter-autoroll mentioned this pull request Jan 18, 2022

Roll Engine from fab19829949d to 50adf4c1f79e (32 revisions) flutter/flutter#96778

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 18, 2022

f9385e7 Remove unused field initializing formal parameters. (flutter/…

7a7dd75

…engine#30822)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unused field initializing formal parameters. #30822

Remove unused field initializing formal parameters. #30822

scheglov commented Jan 12, 2022 •

edited

Loading

flutter-dashboard bot commented Jan 12, 2022

jonahwilliams Jan 12, 2022

jonahwilliams Jan 12, 2022

jonahwilliams Jan 12, 2022

jonahwilliams left a comment

scheglov commented Jan 12, 2022

jonahwilliams commented Jan 12, 2022

Hixie commented Jan 12, 2022

		@@ -252,11 +252,11 @@ class IsolateNameServer {
		SingletonFlutterWindow get window => engine.window;

		class FrameData {

Remove unused field initializing formal parameters. #30822

Remove unused field initializing formal parameters. #30822

Conversation

scheglov commented Jan 12, 2022 • edited Loading

Pre-launch Checklist

flutter-dashboard bot commented Jan 12, 2022

jonahwilliams Jan 12, 2022

Choose a reason for hiding this comment

jonahwilliams Jan 12, 2022

Choose a reason for hiding this comment

jonahwilliams Jan 12, 2022

Choose a reason for hiding this comment

jonahwilliams left a comment

Choose a reason for hiding this comment

scheglov commented Jan 12, 2022

jonahwilliams commented Jan 12, 2022

Hixie commented Jan 12, 2022

scheglov commented Jan 12, 2022 •

edited

Loading