This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add script to download fuchsia sdk from GCS #31026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I believe after this change we'll need to update the repo_utils module to accept properties to be passed to gclient. |
godofredoc
approved these changes
Jan 27, 2022
Member
|
From Triage: @zanderso would like to take a closer look at the implications of this patch. Please hold for an additional review. |
Contributor
Author
|
Will do, for context this is needed to enable |
zanderso
approved these changes
Jan 28, 2022
| # Prints to stderr. | ||
| def eprint(*args, **kwargs): | ||
| print(*args, file=sys.stderr, **kwargs) | ||
|
|
Member
There was a problem hiding this comment.
nit: two lines between top level methods.
Adds a script to download the Fuchsia SDK from a given GCS bucket. This script can run as an optional gclient hook to allow for the Fuchsia architecture to run LSC checks on commits to fuchsia.git.
chaselatta
force-pushed
the
lsc_script
branch
from
90327bc to
75a2442
Compare
chaselatta
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a script to download the Fuchsia SDK from a given GCS bucket.
This script can run as an optional gclient hook to allow for the
Fuchsia architecture to run LSC checks on commits to fuchsia.git.