-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable DisplayList benchmarks to be built on Android #31268
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
6822ef2
to
30dacc6
Compare
deps += [ "//flutter/testing:opengl" ] | ||
} | ||
|
||
if (is_mac || is_ios) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work?
if (is_mac || is_ios) { | |
if ((is_mac && enable_unittests) || is_ios) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would work, but I think it makes more sense to expose the Metal utilities on all platforms that support Metal (iOS & Mac). If there isn't a target that depends on it, it won't get built anyway.
1e7e10f
to
0515610
Compare
This allows the display_list_benchmarks target to be built on Android.