Add clang-analyzer-* and clang-diagnostic-* to .clang-tidy

[zanderso]

The CREATE_NATIVE_ENTRY() pattern used in unit tests results in a lot of clang-analyzer-core.StackAddressEscape warnings due to the closures it gets passed retaining references to local variables. One way to resolve the warnings would be to declare all of those locals as static, however since the tests that use CREATE_NATIVE_ENTRY() are constructed to avoid the possibility of the callback getting called after the lifetime of the locals, that doesn't really seem like an improvement. Instead, this PR turns off checking for clang-analyzer-core.StackAddressEscape in the files where CREATE_NATIVE_ENTRY() and similar patterns are used.

This PR also ignores some warnings flagged due to rapidjson. We should find another json parsing solution, as suggested in flutter/flutter#97680.

Our Objective-C code has a lot of inconsistencies around nullability. @jmagman or @gaaclarke do you know if we already have an issue filed around that?

Related flutter/flutter#93576

[bdero]

LGTM. The blinkenlights on #31098 will be extreme. 😅

[jmagman]

With this config file, no issues found with ./ci/lint.sh --lint-all --variant ios_debug. However with --variant host_debug I see

/Users/m/Projects/engine/src/flutter/fml/synchronization/waitable_event_unittest.cc:34:57: error: Function 'rand' is obsolete because it implements a poor random number generator.  Use 'arc4random' instead [clang-analyzer-security.insecureAPI.rand,-warnings-as-errors]
      TimeDelta::FromMilliseconds(static_cast<unsigned>(rand()) % 20u);
                                                        ^~~~
/Users/m/Projects/engine/src/flutter/fml/synchronization/waitable_event_unittest.cc:34:57: note: Function 'rand' is obsolete because it implements a poor random number generator.  Use 'arc4random' instead
      TimeDelta::FromMilliseconds(static_cast<unsigned>(rand()) % 20u);
                                                        ^~~~
/Users/m/Projects/engine/src/flutter/fml/synchronization/waitable_event_unittest.cc:76:13: error: Function 'rand' is obsolete because it implements a poor random number generator.  Use 'arc4random' instead [clang-analyzer-security.insecureAPI.rand,-warnings-as-errors]
        if (rand() % 2 == 0) {
            ^~~~
/Users/m/Projects/engine/src/flutter/fml/synchronization/waitable_event_unittest.cc:76:13: note: Function 'rand' is obsolete because it implements a poor random number generator.  Use 'arc4random' instead
        if (rand() % 2 == 0) {
            ^~~~
/Users/m/Projects/engine/src/flutter/fml/synchronization/waitable_event_unittest.cc:161:15: error: Function 'rand' is obsolete because it implements a poor random number generator.  Use 'arc4random' instead [clang-analyzer-security.insecureAPI.rand,-warnings-as-errors]
          if (rand() % 2 == 0) {
              ^~~~
/Users/m/Projects/engine/src/flutter/fml/synchronization/waitable_event_unittest.cc:161:15: note: Function 'rand' is obsolete because it implements a poor random number generator.  Use 'arc4random' instead
          if (rand() % 2 == 0) {

Not sure why the impeller headers aren't found:

/Users/m/Projects/engine/src/out/host_debug/../../flutter/impeller/entity/content_context.h:12:10: error: 'flutter/impeller/entity/gradient_fill.frag.h' file not found [clang-diagnostic-error]
#include "flutter/impeller/entity/gradient_fill.frag.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Since that linter runs during the pre-push githooks I think those errors need to be fixed before this can merge, or pushes from Mac development machines will be blocked for commits that make changes to those files.

engine/tools/githooks/lib/src/pre_push_command.dart

Lines 40 to 46 in 6f99a71

	final io.File compileCommands = io.File(path.join(
	flutterRoot,
	'..',
	'out',
	'host_debug',
	'compile_commands.json',
	));

[jmagman]

Here's the full output:
lint-output.txt

And here are the error (not warning) counts:

  30 clang-analyzer-core.StackAddressEscape
   1 clang-analyzer-cplusplus.NewDeleteLeaks
   1 clang-analyzer-optin.osx.cocoa.localizability.NonLocalizedStringChecker
   3 clang-analyzer-security.insecureAPI.rand
   1 clang-analyzer-security.insecureAPI.strcpy

[jmagman]

#31333 fixes macOS host_debug except the 30 clang-analyzer-core.StackAddressEscape errors.

[jmagman]

Our Objective-C code has a lot of inconsistencies around nullability.

I didn't see any nullability errors running the linter on top of this PR, which ones were you seeing?

[zanderso]

Our Objective-C code has a lot of inconsistencies around nullability.

I didn't see any nullability errors running the linter on top of this PR, which ones were you seeing?

The PR silences them in the .clang-tidy file.

[zanderso]

Thanks, Jenn! I think I've addressed the host_debug issues on macOS.

[jmagman]

The PR silences them in the .clang-tidy file.

Oh right, missed the -.

I think I've addressed the host_debug issues on macOS.

Tested locally, LGTM, thanks @zanderso!