Reland: Fix first batch of warnings in the Android embedding #31530
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
blasten
force-pushed
the
reland_fix_warnings
branch
from
e141ba2 to
6863a83
Compare
blasten
added
the
waiting for tree to go green
| @@ -25,9 +27,11 @@ public PlatformViewFactory(MessageCodec<Object> createArgsCodec) { | |||
| * createArgsCodec argument passed to the constructor. This is null if createArgsCodec was | |||
| * null, or no arguments were sent from the Flutter app. | |||
| */ | |||
| public abstract PlatformView create(Context context, int viewId, Object args); | |||
| @NonNull | |||
| public abstract PlatformView create(@Nullable Context context, int viewId, @Nullable Object args); | |||
There was a problem hiding this comment.
Is there a reason why the context is nullable here?
There was a problem hiding this comment.
Can someone please elaborate here? The context is usually required as NonNull when creating and Android view. I would like to know what is the reason to make this change here.
Relands #30807
Fixes:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20firebase_abstract_method_smoke_test/25243/overview